niansa-misc/glibc
1
0
Fork 0
mirror of git://sourceware.org/git/glibc.git synced 2025-03-06 20:58:33 +01:00
Code Issues Projects Releases Packages Wiki Activity

sysdeps/ieee754: prevent maybe-uninitialized errors with -O [BZ #19444]

Browse source 
With -O included in CFLAGS it fails to build with:

../sysdeps/ieee754/ldbl-96/e_jnl.c: In function '__ieee754_jnl':
../sysdeps/ieee754/ldbl-96/e_jnl.c:146:20: error: 'temp' may be used uninitialized in this function [-Werror=maybe-uninitialized]
      b = invsqrtpi * temp / sqrtl (x);
          ~~~~~~~~~~^~~~~~
../sysdeps/ieee754/ldbl-96/e_jnl.c: In function '__ieee754_ynl':
../sysdeps/ieee754/ldbl-96/e_jnl.c:375:16: error: 'temp' may be used uninitialized in this function [-Werror=maybe-uninitialized]
  b = invsqrtpi * temp / sqrtl (x);
      ~~~~~~~~~~^~~~~~
../sysdeps/ieee754/dbl-64/e_jn.c: In function '__ieee754_jn':
../sysdeps/ieee754/dbl-64/e_jn.c:113:20: error: 'temp' may be used uninitialized in this function [-Werror=maybe-uninitialized]
      b = invsqrtpi * temp / sqrt (x);
          ~~~~~~~~~~^~~~~~
../sysdeps/ieee754/dbl-64/e_jn.c: In function '__ieee754_yn':
../sysdeps/ieee754/dbl-64/e_jn.c:320:16: error: 'temp' may be used uninitialized in this function [-Werror=maybe-uninitialized]
  b = invsqrtpi * temp / sqrt (x);
      ~~~~~~~~~~^~~~~~

Build tested with Yocto for ARM, AARCH64, X86, X86_64, PPC, MIPS, MIPS64
with -O, -O1, -Os.
For AARCH64 it needs one more fix in locale for -Os:
https://sourceware.org/ml/libc-alpha/2018-09/msg00539.html

	[BZ #19444]
	* sysdeps/ieee754/dbl-64/e_jn.c (__ieee754_jn): Use
	__builtin_unreachable for default case in switch.
	(__ieee754_yn): Likewise.
	* sysdeps/ieee754/ldbl-96/e_jnl.c (__ieee754_jnl): Likewise.
	(__ieee754_ynl): Likewise.
	* sysdeps/ieee754/ldbl-128/e_jnl.c (__ieee754_jnl): Likewise.
	(__ieee754_ynl): Likewise.
	* sysdeps/ieee754/ldbl-128ibm/e_jnl.c (__ieee754_jnl): Likewise.
	(__ieee754_ynl): Likewise.
This commit is contained in:
Martin Jansa 2019-01-04 16:17:48 +00:00 • committed by Joseph Myers
parent 8b18d418bd
commit 27c5e756a2
5 changed files with 27 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
ChangeLog
View file

@ -1,3 +1,16 @@
2019-10-04 Martin Jansa <Martin.Jansa@gmail.com>
[BZ #19444]
* sysdeps/ieee754/dbl-64/e_jn.c (__ieee754_jn): Use
__builtin_unreachable for default case in switch.
(__ieee754_yn): Likewise.
* sysdeps/ieee754/ldbl-96/e_jnl.c (__ieee754_jnl): Likewise.
(__ieee754_ynl): Likewise.
* sysdeps/ieee754/ldbl-128/e_jnl.c (__ieee754_jnl): Likewise.
(__ieee754_ynl): Likewise.
* sysdeps/ieee754/ldbl-128ibm/e_jnl.c (__ieee754_jnl): Likewise.
(__ieee754_ynl): Likewise.
2019-01-04 Szabolcs Nagy <szabolcs.nagy@arm.com> 2019-01-04 Szabolcs Nagy <szabolcs.nagy@arm.com>
* manual/maint.texi: Use @{ and @}. * manual/maint.texi: Use @{ and @}.

2
sysdeps/ieee754/dbl-64/e_jn.c
View file

@ -109,6 +109,7 @@ __ieee754_jn (int n, double x)
case 1: temp = -c + s; break; case 1: temp = -c + s; break;
case 2: temp = -c - s; break; case 2: temp = -c - s; break;
case 3: temp = c - s; break; case 3: temp = c - s; break;
default: __builtin_unreachable ();
} }
b = invsqrtpi * temp / sqrt (x); b = invsqrtpi * temp / sqrt (x);
} }
@ -316,6 +317,7 @@ __ieee754_yn (int n, double x)
case 1: temp = -s - c; break; case 1: temp = -s - c; break;
case 2: temp = -s + c; break; case 2: temp = -s + c; break;
case 3: temp = s + c; break; case 3: temp = s + c; break;
default: __builtin_unreachable ();
} }
b = invsqrtpi * temp / sqrt (x); b = invsqrtpi * temp / sqrt (x);
} }

4
sysdeps/ieee754/ldbl-128/e_jnl.c
View file

@ -150,6 +150,8 @@ __ieee754_jnl (int n, _Float128 x)
case 3: case 3:
temp = c - s; temp = c - s;
break; break;
default:
__builtin_unreachable ();
} }
b = invsqrtpi * temp / sqrtl (x); b = invsqrtpi * temp / sqrtl (x);
} }
@ -386,6 +388,8 @@ __ieee754_ynl (int n, _Float128 x)
case 3: case 3:
temp = s + c; temp = s + c;
break; break;
default:
__builtin_unreachable ();
} }
b = invsqrtpi * temp / sqrtl (x); b = invsqrtpi * temp / sqrtl (x);
} }

4
sysdeps/ieee754/ldbl-128ibm/e_jnl.c
View file

@ -150,6 +150,8 @@ __ieee754_jnl (int n, long double x)
case 3: case 3:
temp = c - s; temp = c - s;
break; break;
default:
__builtin_unreachable ();
} }
b = invsqrtpi * temp / sqrtl (x); b = invsqrtpi * temp / sqrtl (x);
} }
@ -386,6 +388,8 @@ __ieee754_ynl (int n, long double x)
case 3: case 3:
temp = s + c; temp = s + c;
break; break;
default:
__builtin_unreachable ();
} }
b = invsqrtpi * temp / sqrtl (x); b = invsqrtpi * temp / sqrtl (x);
} }

4
sysdeps/ieee754/ldbl-96/e_jnl.c
View file

@ -143,6 +143,8 @@ __ieee754_jnl (int n, long double x)
case 3: case 3:
temp = c - s; temp = c - s;
break; break;
default:
__builtin_unreachable ();
} }
b = invsqrtpi * temp / sqrtl (x); b = invsqrtpi * temp / sqrtl (x);
} }
@ -372,6 +374,8 @@ __ieee754_ynl (int n, long double x)
case 3: case 3:
temp = s + c; temp = s + c;
break; break;
default:
__builtin_unreachable ();
} }
b = invsqrtpi * temp / sqrtl (x); b = invsqrtpi * temp / sqrtl (x);
} }