mirror of
git://sourceware.org/git/glibc.git
synced 2025-03-06 20:58:33 +01:00
math: Fix non-portability in the computation of signgam in lgammaf
The k>>31 in signgam = 1 - (((k&(k>>31))&1)<<1); is not portable: * The ISO C standard says "If E1 has a signed type and a negative value, the resulting value is implementation-defined." (this is still in C23). * If the int type is larger than 32 bits (e.g. a 64-bit type), then k = INT_MAX; line 144 will make k>>31 put 1 in bit 0 (thus signgam will be -1) while 0 is expected. Moreover, instead of the fx >= 0x1p31f condition, testing fx >= 0 is probably better for 2 reasons: The signgam expression has more or less a condition on the sign of fx (the goal of k>>31, which can be dropped with this new condition). Since fx ≥ 0 should be the most common case, one can get signgam directly in this case (value 1). And this simplifies the expression for the other case (fx < 0). This new condition may be easier/faster to test on the processor (e.g. by avoiding a load of a constant from the memory). This is commit d41459c731865516318f813cf4c966dafa0eecbf from CORE-MATH. Checked on x86_64-linux-gnu.
This commit is contained in:
parent
c621d4f74f
commit
68d7128942
1 changed files with 4 additions and 5 deletions
|
@ -181,12 +181,11 @@ __ieee754_lgammaf_r (float x, int *signgamp)
|
|||
Note that for a binary32 |x| >= 2^23, x is necessarily an integer,
|
||||
and we already dealed with negative integers, thus now:
|
||||
-2^23 < x < +Inf and x is not a negative integer nor 0, 1, 2. */
|
||||
int k;
|
||||
if (__builtin_expect (fx >= 0x1p31f, 0))
|
||||
k = INT_MAX;
|
||||
if (__glibc_unlikely (fx >= 0))
|
||||
*signgamp = 1;
|
||||
else
|
||||
k = fx;
|
||||
*signgamp = 1 - (((k & (k >> 31)) & 1) << 1);
|
||||
/* gamma(x) is negative in (-2n-1,-2n), thus when fx is odd. */
|
||||
*signgamp = 1 - ((((int) fx) & 1) << 1);
|
||||
|
||||
double z = ax, f;
|
||||
if (__glibc_unlikely (ax < 0x1.52p-1f))
|
||||
|
|
Loading…
Add table
Reference in a new issue