mirror of
git://sourceware.org/git/glibc.git
synced 2025-03-06 20:58:33 +01:00
9e51ae3cd0
Single-precision remainderf() and quad-precision remainderl() implementation derived from Sun is affected by an issue when the result is +-0. IEEE754 requires that if remainder(x, y) = 0, its sign shall be that of x regardless of the rounding direction. The implementation seems to have assumed that x - x = +0 in all rounding modes, which is not the case. When rounding direction is roundTowardNegative the sign of an exact zero sum (or difference) is −0. Regression tests that triggered this erroneous behavior are added to math/libm-test-remainder.inc. Tested for cross riscv64 and powerpc. Original fix by: Bruce Evans <bde@FreeBSD.org> in FreeBSD's a2ddfa5ea726c56dbf825763ad371c261b89b7c7. Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
65 lines
1.5 KiB
C
65 lines
1.5 KiB
C
/* e_remainderf.c -- float version of e_remainder.c.
|
|
*/
|
|
|
|
/*
|
|
* ====================================================
|
|
* Copyright (C) 1993 by Sun Microsystems, Inc. All rights reserved.
|
|
*
|
|
* Developed at SunPro, a Sun Microsystems, Inc. business.
|
|
* Permission to use, copy, modify, and distribute this
|
|
* software is freely granted, provided that this notice
|
|
* is preserved.
|
|
* ====================================================
|
|
*/
|
|
|
|
#include <math.h>
|
|
#include <math_private.h>
|
|
#include <libm-alias-finite.h>
|
|
|
|
static const float zero = 0.0;
|
|
|
|
|
|
float
|
|
__ieee754_remainderf(float x, float p)
|
|
{
|
|
int32_t hx,hp;
|
|
uint32_t sx;
|
|
float p_half;
|
|
|
|
GET_FLOAT_WORD(hx,x);
|
|
GET_FLOAT_WORD(hp,p);
|
|
sx = hx&0x80000000;
|
|
hp &= 0x7fffffff;
|
|
hx &= 0x7fffffff;
|
|
|
|
/* purge off exception values */
|
|
if(hp==0) return (x*p)/(x*p); /* p = 0 */
|
|
if((hx>=0x7f800000)|| /* x not finite */
|
|
((hp>0x7f800000))) /* p is NaN */
|
|
return (x*p)/(x*p);
|
|
|
|
|
|
if (hp<=0x7effffff) x = __ieee754_fmodf(x,p+p); /* now x < 2p */
|
|
if ((hx-hp)==0) return zero*x;
|
|
x = fabsf(x);
|
|
p = fabsf(p);
|
|
if (hp<0x01000000) {
|
|
if(x+x>p) {
|
|
x-=p;
|
|
if(x+x>=p) x -= p;
|
|
}
|
|
} else {
|
|
p_half = (float)0.5*p;
|
|
if(x>p_half) {
|
|
x-=p;
|
|
if(x>=p_half) x -= p;
|
|
}
|
|
}
|
|
GET_FLOAT_WORD(hx,x);
|
|
/* Make sure x is not -0. This can occur only when x = p
|
|
and rounding direction is towards negative infinity. */
|
|
if (hx==0x80000000) hx = 0;
|
|
SET_FLOAT_WORD(x,hx^sx);
|
|
return x;
|
|
}
|
|
libm_alias_finite (__ieee754_remainderf, __remainderf)
|