niansa-misc/linux
1
0
Fork 0
mirror of synced 2025-03-06 20:59:54 +01:00
Code Issues Projects Releases Packages Wiki Activity

platform/chrome: cros_ec_uart: fix race condition

Browse source 
serdev_device_set_client_ops() is called before `ec_dev` is fully
initialized.  This can result in cros_ec_uart_rx_bytes() being called
while `ec_dev` is still not initialized, resulting in a kernel panic.

Call serdev_device_set_client_ops() after `ec_dev` is initialized.

Fixes: 04a8bdd135 ("platform/chrome: cros_ec_uart: Add transport layer")
Signed-off-by: Robert Zieba <robertzieba@google.com>
[tzungbi: modified commit message and fixed context conflict.]
Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
Link: https://lore.kernel.org/r/20221229094738.2304044-1-tzungbi@kernel.org
This commit is contained in:
Robert Zieba 2022-12-29 17:47:38 +08:00 • committed by Tzung-Bi Shih
parent f9bce00f78
commit 01f95d42b8
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
drivers/platform/chrome/cros_ec_uart.c
View file

@ -270,7 +270,6 @@ static int cros_ec_uart_probe(struct serdev_device *serdev)
}
serdev_device_set_drvdata(serdev, ec_dev);
serdev_device_set_client_ops(serdev, &cros_ec_uart_client_ops);
init_waitqueue_head(&ec_uart->response.wait_queue);
ec_uart->serdev = serdev;
@ -300,6 +299,8 @@ static int cros_ec_uart_probe(struct serdev_device *serdev)
sizeof(struct ec_response_get_protocol_info);
ec_dev->dout_size = sizeof(struct ec_host_request);
serdev_device_set_client_ops(serdev, &cros_ec_uart_client_ops);
return cros_ec_register(ec_dev);
}