niansa-misc/linux
1
0
Fork 0
mirror of synced 2025-03-06 20:59:54 +01:00
Code Issues Projects Releases Packages Wiki Activity

drm/selftests/test-drm_dp_mst_helper: Move 'sideband_msg_req_encode_decode' onto the heap

Browse source 
There is too much data being stored on the stack.

Fixes the following W=1 kernel build warning(s):

 drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c: In function ‘sideband_msg_req_encode_decode’:
 drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c:168:1: warning: the frame size of 1072 bytes is larger than 1024 bytes [-Wframe-larger-than=]

Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20201116174112.1833368-31-lee.jones@linaro.org
This commit is contained in:
Lee Jones 2020-11-16 17:41:00 +00:00 • committed by Daniel Vetter
parent ffefe45a2d
commit 09234b88ef
1 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c
View file

@ -122,7 +122,7 @@ sideband_msg_req_encode_decode(struct drm_dp_sideband_msg_req_body *in)
{ {
struct drm_dp_sideband_msg_req_body *out; struct drm_dp_sideband_msg_req_body *out;
struct drm_printer p = drm_err_printer(PREFIX_STR); struct drm_printer p = drm_err_printer(PREFIX_STR);
struct drm_dp_sideband_msg_tx txmsg; struct drm_dp_sideband_msg_tx *txmsg;
int i, ret; int i, ret;
bool result = true; bool result = true;
@ -130,8 +130,12 @@ sideband_msg_req_encode_decode(struct drm_dp_sideband_msg_req_body *in)
if (!out) if (!out)
return false; return false;
drm_dp_encode_sideband_req(in, &txmsg); txmsg = kzalloc(sizeof(*txmsg), GFP_KERNEL);
ret = drm_dp_decode_sideband_req(&txmsg, out); if (!txmsg)
return false;
drm_dp_encode_sideband_req(in, txmsg);
ret = drm_dp_decode_sideband_req(txmsg, out);
if (ret < 0) { if (ret < 0) {
drm_printf(&p, "Failed to decode sideband request: %d\n", drm_printf(&p, "Failed to decode sideband request: %d\n",
ret); ret);
@ -166,6 +170,7 @@ sideband_msg_req_encode_decode(struct drm_dp_sideband_msg_req_body *in)
out: out:
kfree(out); kfree(out);
kfree(txmsg);
return result; return result;
} }