niansa-misc/linux
1
0
Fork 0
mirror of synced 2025-03-06 20:59:54 +01:00
Code Issues Projects Releases Packages Wiki Activity

usb: musb: da8xx: Call earlier clk_prepare_enable()

Browse source 
The first attempt to read a register may fail because the clock may not
be enabled, and then the probe of musb driver will fail.
Call clk_prepare_enable() before the first register read.

Signed-off-by: Alexandre Bailon <abailon@baylibre.com>
Signed-off-by: Bin Liu <b-liu@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Alexandre Bailon 2016-11-21 08:59:30 -06:00 • committed by Greg Kroah-Hartman
parent 35bd67b2e5
commit 09721ba6da
1 changed files with 8 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
drivers/usb/musb/da8xx.c
View file

@ -369,6 +369,12 @@ static int da8xx_musb_init(struct musb *musb)
musb->mregs += DA8XX_MENTOR_CORE_OFFSET; musb->mregs += DA8XX_MENTOR_CORE_OFFSET;
ret = clk_prepare_enable(glue->clk);
if (ret) {
dev_err(glue->dev, "failed to enable clock\n");
return ret;
}
/* Returns zero if e.g. not clocked */ /* Returns zero if e.g. not clocked */
rev = musb_readl(reg_base, DA8XX_USB_REVISION_REG); rev = musb_readl(reg_base, DA8XX_USB_REVISION_REG);
if (!rev) if (!rev)
@ -380,12 +386,6 @@ static int da8xx_musb_init(struct musb *musb)
goto fail; goto fail;
} }
ret = clk_prepare_enable(glue->clk);
if (ret) {
dev_err(glue->dev, "failed to enable clock\n");
goto fail;
}
setup_timer(&otg_workaround, otg_timer, (unsigned long)musb); setup_timer(&otg_workaround, otg_timer, (unsigned long)musb);
/* Reset the controller */ /* Reset the controller */
@ -395,7 +395,7 @@ static int da8xx_musb_init(struct musb *musb)
ret = phy_init(glue->phy); ret = phy_init(glue->phy);
if (ret) { if (ret) {
dev_err(glue->dev, "Failed to init phy.\n"); dev_err(glue->dev, "Failed to init phy.\n");
goto err_phy_init; goto fail;
} }
ret = phy_power_on(glue->phy); ret = phy_power_on(glue->phy);
@ -415,9 +415,8 @@ static int da8xx_musb_init(struct musb *musb)
err_phy_power_on: err_phy_power_on:
phy_exit(glue->phy); phy_exit(glue->phy);
err_phy_init:
clk_disable_unprepare(glue->clk);
fail: fail:
clk_disable_unprepare(glue->clk);
return ret; return ret;
} }