niansa-misc/linux
1
0
Fork 0
mirror of synced 2025-03-06 20:59:54 +01:00
Code Issues Projects Releases Packages Wiki Activity

drm/radeon: Prefer pr_err/_info over printk

Browse source 
Fixes the following checkpatch.pl:

WARNING: printk() should include KERN_<LEVEL> facility level

Cc: Christian König <christian.koenig@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@amd.com>
Reviewed-by: Guchun Chen <guchun.chen@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
This commit is contained in:
Srinivasan Shanmugam 2023-07-19 16:31:48 +05:30 • committed by Alex Deucher
parent 5dbb59247b
commit 09edeb4c16
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
drivers/gpu/drm/radeon/radeon_atpx_handler.c
View file

@ -115,7 +115,7 @@ static union acpi_object *radeon_atpx_call(acpi_handle handle, int function,
/* Fail only if calling the method fails and ATPX is supported */ /* Fail only if calling the method fails and ATPX is supported */
if (ACPI_FAILURE(status) && status != AE_NOT_FOUND) { if (ACPI_FAILURE(status) && status != AE_NOT_FOUND) {
printk("failed to evaluate ATPX got %s\n", pr_err("failed to evaluate ATPX got %s\n",
acpi_format_exception(status)); acpi_format_exception(status));
kfree(buffer.pointer); kfree(buffer.pointer);
return NULL; return NULL;
@ -171,7 +171,7 @@ static int radeon_atpx_validate(struct radeon_atpx *atpx)
size = *(u16 *) info->buffer.pointer; size = *(u16 *) info->buffer.pointer;
if (size < 10) { if (size < 10) {
printk("ATPX buffer is too small: %zu\n", size); pr_err("ATPX buffer is too small: %zu\n", size);
kfree(info); kfree(info);
return -EINVAL; return -EINVAL;
} }
@ -202,7 +202,7 @@ static int radeon_atpx_validate(struct radeon_atpx *atpx)
atpx->is_hybrid = false; atpx->is_hybrid = false;
if (valid_bits & ATPX_MS_HYBRID_GFX_SUPPORTED) { if (valid_bits & ATPX_MS_HYBRID_GFX_SUPPORTED) {
printk("ATPX Hybrid Graphics\n"); pr_info("ATPX Hybrid Graphics\n");
/* /*
* Disable legacy PM methods only when pcie port PM is usable, * Disable legacy PM methods only when pcie port PM is usable,
* otherwise the device might fail to power off or power on. * otherwise the device might fail to power off or power on.
@ -239,7 +239,7 @@ static int radeon_atpx_verify_interface(struct radeon_atpx *atpx)
size = *(u16 *) info->buffer.pointer; size = *(u16 *) info->buffer.pointer;
if (size < 8) { if (size < 8) {
printk("ATPX buffer is too small: %zu\n", size); pr_err("ATPX buffer is too small: %zu\n", size);
err = -EINVAL; err = -EINVAL;
goto out; goto out;
} }
@ -248,7 +248,7 @@ static int radeon_atpx_verify_interface(struct radeon_atpx *atpx)
memcpy(&output, info->buffer.pointer, size); memcpy(&output, info->buffer.pointer, size);
/* TODO: check version? */ /* TODO: check version? */
printk("ATPX version %u, functions 0x%08x\n", pr_info("ATPX version %u, functions 0x%08x\n",
output.version, output.function_bits); output.version, output.function_bits);
radeon_atpx_parse_functions(&atpx->functions, output.function_bits); radeon_atpx_parse_functions(&atpx->functions, output.function_bits);