niansa-misc/linux
1
0
Fork 0
mirror of synced 2025-03-06 20:59:54 +01:00
Code Issues Projects Releases Packages Wiki Activity

gpio: mpc8xxx: Fix IRQ check in mpc8xxx_probe

Browse source 
platform_get_irq() returns negative error number instead 0 on failure.
And the doc of platform_get_irq() provides a usage example:

    int irq = platform_get_irq(pdev, 0);
    if (irq < 0)
        return irq;

Fix the check of return value to catch errors correctly.

Fixes: 76c47d1449 ("gpio: mpc8xxx: Add ACPI support")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
This commit is contained in:
Miaoqian Lin 2022-01-14 06:48:20 +00:00 • committed by Bartosz Golaszewski
parent df0cc57e05
commit 0b39536cc6
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/gpio/gpio-mpc8xxx.c
View file

@ -388,8 +388,8 @@ static int mpc8xxx_probe(struct platform_device *pdev)
} }
mpc8xxx_gc->irqn = platform_get_irq(pdev, 0); mpc8xxx_gc->irqn = platform_get_irq(pdev, 0);
if (!mpc8xxx_gc->irqn) if (mpc8xxx_gc->irqn < 0)
return 0; return mpc8xxx_gc->irqn;
mpc8xxx_gc->irq = irq_domain_create_linear(fwnode, mpc8xxx_gc->irq = irq_domain_create_linear(fwnode,
MPC8XXX_GPIO_PINS, MPC8XXX_GPIO_PINS,