niansa-misc/linux
1
0
Fork 0
mirror of synced 2025-03-06 20:59:54 +01:00
Code Issues Projects Releases Packages Wiki Activity

ACPI: bus: Set driver_data to NULL every time .add() fails

Browse source 
Most ACPI drivers set driver_data in their .add() callbacks, but usually
they don't clear it in the error code path.

Set driver_data to NULL in acpi_device_probe() to prevent stale pointers
from staying around.

Signed-off-by: Michal Wilczynski <michal.wilczynski@intel.com>
[ rjw: Subject and changelog edits ]
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
This commit is contained in:
Michal Wilczynski 2023-07-03 11:02:45 +03:00 • committed by Rafael J. Wysocki
parent c542ce36a9
commit 0d16710146
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/acpi/bus.c
View file

@ -1029,8 +1029,10 @@ static int acpi_device_probe(struct device *dev)
return -ENOSYS; return -ENOSYS;
ret = acpi_drv->ops.add(acpi_dev); ret = acpi_drv->ops.add(acpi_dev);
if (ret) if (ret) {
acpi_dev->driver_data = NULL;
return ret; return ret;
}
pr_debug("Driver [%s] successfully bound to device [%s]\n", pr_debug("Driver [%s] successfully bound to device [%s]\n",
acpi_drv->name, acpi_dev->pnp.bus_id); acpi_drv->name, acpi_dev->pnp.bus_id);