niansa-misc/linux
1
0
Fork 0
mirror of synced 2025-03-06 20:59:54 +01:00
Code Issues Projects Releases Packages Wiki Activity

scsi: ibmvscsis: Issues from Dan Carpenter/Smatch

Browse source 
Signed-off-by: Michael Cyr <mikecyr@us.ibm.com>
Signed-off-by: Bryant G. Ly <bryantly@linux.vnet.ibm.com>
Tested-by: Steven Royer <seroyer@linux.vnet.ibm.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Michael Cyr 2016-10-13 11:02:43 -05:00 • committed by Martin K. Petersen
parent 9c93cf03d4
commit 11950d70b5
1 changed files with 3 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
View file

@ -1896,14 +1896,7 @@ static long ibmvscsis_mad(struct scsi_info *vscsi, struct viosrp_crq *crq)
pr_debug("mad: type %d\n", be32_to_cpu(mad->type)); pr_debug("mad: type %d\n", be32_to_cpu(mad->type));
if (be16_to_cpu(mad->length) < 0) { rc = ibmvscsis_process_mad(vscsi, iue);
dev_err(&vscsi->dev, "mad: length is < 0\n");
ibmvscsis_post_disconnect(vscsi,
ERR_DISCONNECT_RECONNECT, 0);
rc = SRP_VIOLATION;
} else {
rc = ibmvscsis_process_mad(vscsi, iue);
}
pr_debug("mad: status %hd, rc %ld\n", be16_to_cpu(mad->status), pr_debug("mad: status %hd, rc %ld\n", be16_to_cpu(mad->status),
rc); rc);
@ -2523,7 +2516,6 @@ static void ibmvscsis_parse_cmd(struct scsi_info *vscsi,
dev_err(&vscsi->dev, "0x%llx: parsing SRP descriptor table failed.\n", dev_err(&vscsi->dev, "0x%llx: parsing SRP descriptor table failed.\n",
srp->tag); srp->tag);
goto fail; goto fail;
return;
} }
cmd->rsp.sol_not = srp->sol_not; cmd->rsp.sol_not = srp->sol_not;
@ -3282,7 +3274,8 @@ static int ibmvscsis_probe(struct vio_dev *vdev,
INIT_LIST_HEAD(&vscsi->waiting_rsp); INIT_LIST_HEAD(&vscsi->waiting_rsp);
INIT_LIST_HEAD(&vscsi->active_q); INIT_LIST_HEAD(&vscsi->active_q);
snprintf(vscsi->tport.tport_name, 256, "%s", dev_name(&vdev->dev)); snprintf(vscsi->tport.tport_name, IBMVSCSIS_NAMELEN, "%s",
dev_name(&vdev->dev));
pr_debug("probe tport_name: %s\n", vscsi->tport.tport_name); pr_debug("probe tport_name: %s\n", vscsi->tport.tport_name);