niansa-misc/linux
1
0
Fork 0
mirror of synced 2025-03-06 20:59:54 +01:00
Code Issues Projects Releases Packages Wiki Activity

mei: push credentials inside the irq write handler

Browse source 
this eventually allows as use a single write queue
both for control and data messages and removing possible
race

Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Tomas Winkler 2013-09-16 23:44:44 +03:00 • committed by Greg Kroah-Hartman
parent 2ebf8c94d4
commit 136698e535
3 changed files with 34 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
drivers/misc/mei/amthif.c
View file

@ -460,6 +460,15 @@ int mei_amthif_irq_write_complete(struct mei_cl *cl, struct mei_cl_cb *cb,
u32 msg_slots = mei_data2slots(len); u32 msg_slots = mei_data2slots(len);
int rets; int rets;
rets = mei_cl_flow_ctrl_creds(cl);
if (rets < 0)
return rets;
if (rets == 0) {
cl_dbg(dev, cl, "No flow control credentials: not sending.\n");
return 0;
}
mei_hdr.host_addr = cl->host_client_id; mei_hdr.host_addr = cl->host_client_id;
mei_hdr.me_addr = cl->me_client_id; mei_hdr.me_addr = cl->me_client_id;
mei_hdr.reserved = 0; mei_hdr.reserved = 0;

30
drivers/misc/mei/client.c
View file

@ -702,12 +702,33 @@ err:
int mei_cl_irq_write_complete(struct mei_cl *cl, struct mei_cl_cb *cb, int mei_cl_irq_write_complete(struct mei_cl *cl, struct mei_cl_cb *cb,
s32 *slots, struct mei_cl_cb *cmpl_list) s32 *slots, struct mei_cl_cb *cmpl_list)
{ {
struct mei_device *dev = cl->dev; struct mei_device *dev;
struct mei_msg_data *buf;
struct mei_msg_hdr mei_hdr; struct mei_msg_hdr mei_hdr;
size_t len = cb->request_buffer.size - cb->buf_idx; size_t len;
u32 msg_slots = mei_data2slots(len); u32 msg_slots;
int rets; int rets;
if (WARN_ON(!cl || !cl->dev))
return -ENODEV;
dev = cl->dev;
buf = &cb->request_buffer;
rets = mei_cl_flow_ctrl_creds(cl);
if (rets < 0)
return rets;
if (rets == 0) {
cl_dbg(dev, cl, "No flow control credentials: not sending.\n");
return 0;
}
len = buf->size - cb->buf_idx;
msg_slots = mei_data2slots(len);
mei_hdr.host_addr = cl->host_client_id; mei_hdr.host_addr = cl->host_client_id;
mei_hdr.me_addr = cl->me_client_id; mei_hdr.me_addr = cl->me_client_id;
mei_hdr.reserved = 0; mei_hdr.reserved = 0;
@ -730,8 +751,7 @@ int mei_cl_irq_write_complete(struct mei_cl *cl, struct mei_cl_cb *cb,
cb->request_buffer.size, cb->buf_idx); cb->request_buffer.size, cb->buf_idx);
*slots -= msg_slots; *slots -= msg_slots;
rets = mei_write_message(dev, &mei_hdr, rets = mei_write_message(dev, &mei_hdr, buf->data + cb->buf_idx);
cb->request_buffer.data + cb->buf_idx);
if (rets) { if (rets) {
cl->status = rets; cl->status = rets;
list_move_tail(&cb->list, &cmpl_list->list); list_move_tail(&cb->list, &cmpl_list->list);

5
drivers/misc/mei/interrupt.c
View file

@ -513,11 +513,6 @@ int mei_irq_write_handler(struct mei_device *dev, struct mei_cl_cb *cmpl_list)
cl = cb->cl; cl = cb->cl;
if (cl == NULL) if (cl == NULL)
continue; continue;
if (mei_cl_flow_ctrl_creds(cl) <= 0) {
cl_dbg(dev, cl, "No flow control credentials, not sending.\n");
continue;
}
if (cl == &dev->iamthif_cl) if (cl == &dev->iamthif_cl)
ret = mei_amthif_irq_write_complete(cl, cb, ret = mei_amthif_irq_write_complete(cl, cb,
&slots, cmpl_list); &slots, cmpl_list);