niansa-misc/linux
1
0
Fork 0
mirror of synced 2025-03-06 20:59:54 +01:00
Code Issues Projects Releases Packages Wiki Activity

net: phy: fix issue with loading PHY driver w/o initramfs

Browse source 
It was reported that on a system with nfsboot and w/o initramfs network
fails because trying to load the PHY driver returns -ENOENT. Reason was
that due to missing initramfs the modprobe binary isn't available.
So we have to ignore error code -ENOENT.

Fixes: 13d0ab6750 ("net: phy: check return code when requesting PHY driver module")
Reported-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Tested-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Heiner Kallweit 2019-01-19 10:30:21 +01:00 • committed by David S. Miller
parent 0da2b1832c
commit 21e194425a
1 changed files with 5 additions and 3 deletions

8
drivers/net/phy/phy_device.c
View file

@ -564,10 +564,12 @@ static int phy_request_driver_module(struct phy_device *dev, int phy_id)
ret = request_module(MDIO_MODULE_PREFIX MDIO_ID_FMT, ret = request_module(MDIO_MODULE_PREFIX MDIO_ID_FMT,
MDIO_ID_ARGS(phy_id)); MDIO_ID_ARGS(phy_id));
/* we only check for failures in executing the usermode binary, /* We only check for failures in executing the usermode binary,
* not whether a PHY driver module exists for the PHY ID * not whether a PHY driver module exists for the PHY ID.
* Accept -ENOENT because this may occur in case no initramfs exists,
* then modprobe isn't available.
*/ */
if (IS_ENABLED(CONFIG_MODULES) && ret < 0) { if (IS_ENABLED(CONFIG_MODULES) && ret < 0 && ret != -ENOENT) {
phydev_err(dev, "error %d loading PHY driver module for ID 0x%08x\n", phydev_err(dev, "error %d loading PHY driver module for ID 0x%08x\n",
ret, phy_id); ret, phy_id);
return ret; return ret;