niansa-misc/linux
1
0
Fork 0
mirror of synced 2025-03-06 20:59:54 +01:00
Code Issues Projects Releases Packages Wiki Activity

getdelays: fix error format characters

Browse source 
getdelays had a compilation issue because the format string was not
updated when the "delay min" was added.  For example, after adding the
"delay min" in printf, there were 7 strings but only 6 "%s" format
specifiers.  Similarly, after adding the 't->cpu_delay_total', there were
7 variables but only 6 format characters specifiers, causing compilation
issues as follows.  This commit fixes these issues to ensure that
getdelays compiles correctly.

root@xx:~/linux-next/tools/accounting$ make
getdelays.c:199:9: warning: format `%llu' expects argument of type
`long long unsigned int', but argument 8 has type `char *' [-Wformat=]
  199 |  printf("\n\nCPU   %15s%15s%15s%15s%15s%15s\n"
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
.....
  216 |         "delay total", "delay average", "delay max", "delay min",
      |                                                      ~~~~~~~~~~~
      |                                                      |
      |                                                      char *
getdelays.c:200:21: note: format string is defined here
  200 |         "      %15llu%15llu%15llu%15llu%15.3fms%13.6fms\n"
      |                ~~~~~^
      |                     |
      |                     long long unsigned int
      |                %15s
getdelays.c:199:9: warning: format `%f' expects argument of type
`double', but argument 12 has type `long long unsigned int' [-Wformat=]
  199 |  printf("\n\nCPU   %15s%15s%15s%15s%15s%15s\n"
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
.....
  220 |         (unsigned long long)t->cpu_delay_total,
      |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |         |
      |         long long unsigned int
.....

Link: https://lkml.kernel.org/r/20250208144400544RduNRhwIpT3m2JyRBqskZ@zte.com.cn
Fixes: f65c64f311 ("delayacct: add delay min to record delay peak")
Reviewed-by: xu xin <xu.xin16@zte.com.cn>
Signed-off-by: Wang Yaxin <wang.yaxin@zte.com.cn>
Signed-off-by: Kun Jiang <jiang.kun2@zte.com.cn>
Cc: Balbir Singh <bsingharora@gmail.com>
Cc: David Hildenbrand <david@redhat.com>
Cc: Fan Yu <fan.yu9@zte.com.cn>
Cc: Peilin He <he.peilin@zte.com.cn>
Cc: Qiang Tu <tu.qiang35@zte.com.cn>
Cc: wangyong <wang.yong12@zte.com.cn>
Cc: ye xingchen <ye.xingchen@zte.com.cn>
Cc: Yunkai Zhang <zhang.yunkai@zte.com.cn>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
This commit is contained in:
Wang Yaxin 2025-02-08 14:44:00 +08:00 • committed by Andrew Morton
parent 41cddf83d8
commit 2272dbc471
1 changed files with 16 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

32
tools/accounting/getdelays.c
View file

@ -196,22 +196,22 @@ static int get_family_id(int sd)
static void print_delayacct(struct taskstats *t)
{
printf("\n\nCPU %15s%15s%15s%15s%15s%15s\n"
" %15llu%15llu%15llu%15llu%15.3fms%13.6fms\n"
"IO %15s%15s%15s%15s\n"
" %15llu%15llu%15.3fms%13.6fms\n"
"SWAP %15s%15s%15s%15s\n"
" %15llu%15llu%15.3fms%13.6fms\n"
"RECLAIM %12s%15s%15s%15s\n"
" %15llu%15llu%15.3fms%13.6fms\n"
"THRASHING%12s%15s%15s%15s\n"
" %15llu%15llu%15.3fms%13.6fms\n"
"COMPACT %12s%15s%15s%15s\n"
" %15llu%15llu%15.3fms%13.6fms\n"
"WPCOPY %12s%15s%15s%15s\n"
" %15llu%15llu%15.3fms%13.6fms\n"
"IRQ %15s%15s%15s%15s\n"
" %15llu%15llu%15.3fms%13.6fms\n",
printf("\n\nCPU %15s%15s%15s%15s%15s%15s%15s\n"
" %15llu%15llu%15llu%15llu%15.3fms%13.6fms%13.6fms\n"
"IO %15s%15s%15s%15s%15s\n"
" %15llu%15llu%15.3fms%13.6fms%13.6fms\n"
"SWAP %15s%15s%15s%15s%15s\n"
" %15llu%15llu%15.3fms%13.6fms%13.6fms\n"
"RECLAIM %12s%15s%15s%15s%15s\n"
" %15llu%15llu%15.3fms%13.6fms%13.6fms\n"
"THRASHING%12s%15s%15s%15s%15s\n"
" %15llu%15llu%15.3fms%13.6fms%13.6fms\n"
"COMPACT %12s%15s%15s%15s%15s\n"
" %15llu%15llu%15.3fms%13.6fms%13.6fms\n"
"WPCOPY %12s%15s%15s%15s%15s\n"
" %15llu%15llu%15.3fms%13.6fms%13.6fms\n"
"IRQ %15s%15s%15s%15s%15s\n"
" %15llu%15llu%15.3fms%13.6fms%13.6fms\n",
"count", "real total", "virtual total",
"delay total", "delay average", "delay max", "delay min",
(unsigned long long)t->cpu_count,