niansa-misc/linux
1
0
Fork 0
mirror of synced 2025-03-06 20:59:54 +01:00
Code Issues Projects Releases Packages Wiki Activity

genetlink: support split policies in ctrl_dumppolicy_put_op()

Browse source 
Pass do and dump versions of the op to ctrl_dumppolicy_put_op()
so that it can provide a different policy index for the two.

Since we now look at policies, and those are set appropriately
there's no need to look at the GENL_DONT_VALIDATE_DUMP flag.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Jakub Kicinski 2022-11-04 12:13:37 -07:00 • committed by David S. Miller
parent 92d3d9ba9b
commit 26588edbef
1 changed files with 33 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

55
net/netlink/genetlink.c
View file

@ -1345,7 +1345,8 @@ static void *ctrl_dumppolicy_prep(struct sk_buff *skb,
static int ctrl_dumppolicy_put_op(struct sk_buff *skb, static int ctrl_dumppolicy_put_op(struct sk_buff *skb,
struct netlink_callback *cb, struct netlink_callback *cb,
struct genl_ops *op) struct genl_split_ops *doit,
struct genl_split_ops *dumpit)
{ {
struct ctrl_dump_policy_ctx *ctx = (void *)cb->ctx; struct ctrl_dump_policy_ctx *ctx = (void *)cb->ctx;
struct nlattr *nest_pol, *nest_op; struct nlattr *nest_pol, *nest_op;
@ -1353,10 +1354,7 @@ static int ctrl_dumppolicy_put_op(struct sk_buff *skb,
int idx; int idx;
/* skip if we have nothing to show */ /* skip if we have nothing to show */
if (!op->policy) if (!doit->policy && !dumpit->policy)
return 0;
if (!op->doit &&
(!op->dumpit || op->validate & GENL_DONT_VALIDATE_DUMP))
return 0; return 0;
hdr = ctrl_dumppolicy_prep(skb, cb); hdr = ctrl_dumppolicy_prep(skb, cb);
@ -1367,21 +1365,26 @@ static int ctrl_dumppolicy_put_op(struct sk_buff *skb,
if (!nest_pol) if (!nest_pol)
goto err; goto err;
nest_op = nla_nest_start(skb, op->cmd); nest_op = nla_nest_start(skb, doit->cmd);
if (!nest_op) if (!nest_op)
goto err; goto err;
/* for now both do/dump are always the same */ if (doit->policy) {
idx = netlink_policy_dump_get_policy_idx(ctx->state, idx = netlink_policy_dump_get_policy_idx(ctx->state,
op->policy, doit->policy,
op->maxattr); doit->maxattr);
if (op->doit && nla_put_u32(skb, CTRL_ATTR_POLICY_DO, idx)) if (nla_put_u32(skb, CTRL_ATTR_POLICY_DO, idx))
goto err; goto err;
}
if (dumpit->policy) {
idx = netlink_policy_dump_get_policy_idx(ctx->state,
dumpit->policy,
dumpit->maxattr);
if (op->dumpit && !(op->validate & GENL_DONT_VALIDATE_DUMP) && if (nla_put_u32(skb, CTRL_ATTR_POLICY_DUMP, idx))
nla_put_u32(skb, CTRL_ATTR_POLICY_DUMP, idx)) goto err;
goto err; }
nla_nest_end(skb, nest_op); nla_nest_end(skb, nest_op);
nla_nest_end(skb, nest_pol); nla_nest_end(skb, nest_pol);
@ -1399,16 +1402,19 @@ static int ctrl_dumppolicy(struct sk_buff *skb, struct netlink_callback *cb)
void *hdr; void *hdr;
if (!ctx->policies) { if (!ctx->policies) {
struct genl_split_ops doit, dumpit;
struct genl_ops op; struct genl_ops op;
if (ctx->single_op) { if (ctx->single_op) {
int err; if (genl_get_cmd_split(ctx->op, GENL_CMD_CAP_DO,
ctx->rt, &doit) &&
genl_get_cmd_split(ctx->op, GENL_CMD_CAP_DUMP,
ctx->rt, &dumpit)) {
WARN_ON(1);
return -ENOENT;
}
err = genl_get_cmd(ctx->op, ctx->rt, &op); if (ctrl_dumppolicy_put_op(skb, cb, &doit, &dumpit))
if (WARN_ON(err))
return err;
if (ctrl_dumppolicy_put_op(skb, cb, &op))
return skb->len; return skb->len;
/* don't enter the loop below */ /* don't enter the loop below */
@ -1418,7 +1424,12 @@ static int ctrl_dumppolicy(struct sk_buff *skb, struct netlink_callback *cb)
while (ctx->opidx < genl_get_cmd_cnt(ctx->rt)) { while (ctx->opidx < genl_get_cmd_cnt(ctx->rt)) {
genl_get_cmd_by_index(ctx->opidx, ctx->rt, &op); genl_get_cmd_by_index(ctx->opidx, ctx->rt, &op);
if (ctrl_dumppolicy_put_op(skb, cb, &op)) genl_cmd_full_to_split(&doit, ctx->rt,
&op, GENL_CMD_CAP_DO);
genl_cmd_full_to_split(&dumpit, ctx->rt,
&op, GENL_CMD_CAP_DUMP);
if (ctrl_dumppolicy_put_op(skb, cb, &doit, &dumpit))
return skb->len; return skb->len;
ctx->opidx++; ctx->opidx++;