niansa-misc/linux
1
0
Fork 0
mirror of synced 2025-03-06 20:59:54 +01:00
Code Issues Projects Releases Packages Wiki Activity

net: ethernet: xilinx: Convert to platform remove callback returning void

Browse source 
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() is renamed to .remove().

Trivially convert these drivers from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Uwe Kleine-König 2023-09-18 22:42:25 +02:00 • committed by David S. Miller
parent 46b5668494
commit 2e0ec0afa9
3 changed files with 6 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
drivers/net/ethernet/xilinx/ll_temac_main.c
View file

@ -1626,7 +1626,7 @@ err_sysfs_create:
return rc; return rc;
} }
static int temac_remove(struct platform_device *pdev) static void temac_remove(struct platform_device *pdev)
{ {
struct net_device *ndev = platform_get_drvdata(pdev); struct net_device *ndev = platform_get_drvdata(pdev);
struct temac_local *lp = netdev_priv(ndev); struct temac_local *lp = netdev_priv(ndev);
@ -1636,7 +1636,6 @@ static int temac_remove(struct platform_device *pdev)
if (lp->phy_node) if (lp->phy_node)
of_node_put(lp->phy_node); of_node_put(lp->phy_node);
temac_mdio_teardown(lp); temac_mdio_teardown(lp);
return 0;
} }
static const struct of_device_id temac_of_match[] = { static const struct of_device_id temac_of_match[] = {
@ -1650,7 +1649,7 @@ MODULE_DEVICE_TABLE(of, temac_of_match);
static struct platform_driver temac_driver = { static struct platform_driver temac_driver = {
.probe = temac_probe, .probe = temac_probe,
.remove = temac_remove, .remove_new = temac_remove,
.driver = { .driver = {
.name = "xilinx_temac", .name = "xilinx_temac",
.of_match_table = temac_of_match, .of_match_table = temac_of_match,

6
drivers/net/ethernet/xilinx/xilinx_axienet_main.c
View file

@ -2183,7 +2183,7 @@ free_netdev:
return ret; return ret;
} }
static int axienet_remove(struct platform_device *pdev) static void axienet_remove(struct platform_device *pdev)
{ {
struct net_device *ndev = platform_get_drvdata(pdev); struct net_device *ndev = platform_get_drvdata(pdev);
struct axienet_local *lp = netdev_priv(ndev); struct axienet_local *lp = netdev_priv(ndev);
@ -2202,8 +2202,6 @@ static int axienet_remove(struct platform_device *pdev)
clk_disable_unprepare(lp->axi_clk); clk_disable_unprepare(lp->axi_clk);
free_netdev(ndev); free_netdev(ndev);
return 0;
} }
static void axienet_shutdown(struct platform_device *pdev) static void axienet_shutdown(struct platform_device *pdev)
@ -2256,7 +2254,7 @@ static DEFINE_SIMPLE_DEV_PM_OPS(axienet_pm_ops,
static struct platform_driver axienet_driver = { static struct platform_driver axienet_driver = {
.probe = axienet_probe, .probe = axienet_probe,
.remove = axienet_remove, .remove_new = axienet_remove,
.shutdown = axienet_shutdown, .shutdown = axienet_shutdown,
.driver = { .driver = {
.name = "xilinx_axienet", .name = "xilinx_axienet",

6
drivers/net/ethernet/xilinx/xilinx_emaclite.c
View file

@ -1183,7 +1183,7 @@ error:
* *
* Return: 0, always. * Return: 0, always.
*/ */
static int xemaclite_of_remove(struct platform_device *of_dev) static void xemaclite_of_remove(struct platform_device *of_dev)
{ {
struct net_device *ndev = platform_get_drvdata(of_dev); struct net_device *ndev = platform_get_drvdata(of_dev);
@ -1202,8 +1202,6 @@ static int xemaclite_of_remove(struct platform_device *of_dev)
lp->phy_node = NULL; lp->phy_node = NULL;
free_netdev(ndev); free_netdev(ndev);
return 0;
} }
#ifdef CONFIG_NET_POLL_CONTROLLER #ifdef CONFIG_NET_POLL_CONTROLLER
@ -1262,7 +1260,7 @@ static struct platform_driver xemaclite_of_driver = {
.of_match_table = xemaclite_of_match, .of_match_table = xemaclite_of_match,
}, },
.probe = xemaclite_of_probe, .probe = xemaclite_of_probe,
.remove = xemaclite_of_remove, .remove_new = xemaclite_of_remove,
}; };
module_platform_driver(xemaclite_of_driver); module_platform_driver(xemaclite_of_driver);