niansa-misc/linux
1
0
Fork 0
mirror of synced 2025-03-06 20:59:54 +01:00
Code Issues Projects Releases Packages Wiki Activity

x86/microcode: Do not upload microcode if CPUs are offline

Browse source 
Avoid loading microcode if any of the CPUs are offline, and issue a
warning. Having different microcode revisions on the system at any time
is outright dangerous.

[ Borislav: Massage changelog. ]

Signed-off-by: Ashok Raj <ashok.raj@intel.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Tom Lendacky <thomas.lendacky@amd.com>
Tested-by: Ashok Raj <ashok.raj@intel.com>
Reviewed-by: Tom Lendacky <thomas.lendacky@amd.com>
Cc: Arjan Van De Ven <arjan.van.de.ven@intel.com>
Link: http://lkml.kernel.org/r/1519352533-15992-4-git-send-email-ashok.raj@intel.com
Link: https://lkml.kernel.org/r/20180228102846.13447-5-bp@alien8.de
This commit is contained in:
Ashok Raj 2018-02-28 11:28:43 +01:00 • committed by Thomas Gleixner
parent 91df9fdf51
commit 30ec26da99
1 changed files with 18 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
arch/x86/kernel/cpu/microcode/core.c
View file

@ -486,6 +486,16 @@ static void __exit microcode_dev_exit(void)
/* fake device for request_firmware */ /* fake device for request_firmware */
static struct platform_device *microcode_pdev; static struct platform_device *microcode_pdev;
static int check_online_cpus(void)
{
if (num_online_cpus() == num_present_cpus())
return 0;
pr_err("Not all CPUs online, aborting microcode update.\n");
return -EINVAL;
}
static enum ucode_state reload_for_cpu(int cpu) static enum ucode_state reload_for_cpu(int cpu)
{ {
struct ucode_cpu_info *uci = ucode_cpu_info + cpu; struct ucode_cpu_info *uci = ucode_cpu_info + cpu;
@ -519,7 +529,13 @@ static ssize_t reload_store(struct device *dev,
return size; return size;
get_online_cpus(); get_online_cpus();
ret = check_online_cpus();
if (ret)
goto put;
mutex_lock(&microcode_mutex); mutex_lock(&microcode_mutex);
for_each_online_cpu(cpu) { for_each_online_cpu(cpu) {
tmp_ret = reload_for_cpu(cpu); tmp_ret = reload_for_cpu(cpu);
if (tmp_ret > UCODE_NFOUND) { if (tmp_ret > UCODE_NFOUND) {
@ -538,6 +554,8 @@ static ssize_t reload_store(struct device *dev,
microcode_check(); microcode_check();
mutex_unlock(&microcode_mutex); mutex_unlock(&microcode_mutex);
put:
put_online_cpus(); put_online_cpus();
if (!ret) if (!ret)