niansa-misc/linux
1
0
Fork 0
mirror of synced 2025-03-06 20:59:54 +01:00
Code Issues Projects Releases Packages Wiki Activity

pwm: Let the of_xlate callbacks accept references without period

Browse source 
With this extension of_pwm_xlate_with_flags() is suitable to replace the
custom xlate function of the pwm-clps711x driver.

While touching these very similar functions align their implementations.

Link: https://lore.kernel.org/r/127622315d07d9d419ae8e6373c7e5be7fab7a62.1704835845.git.u.kleine-koenig@pengutronix.de
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
This commit is contained in:
Uwe Kleine-König 2024-01-09 22:34:33 +01:00
parent 4e77431cda
commit 40ade0c2e7
1 changed files with 9 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
drivers/pwm/core.c
View file

@ -107,8 +107,8 @@ of_pwm_xlate_with_flags(struct pwm_chip *chip, const struct of_phandle_args *arg
{ {
struct pwm_device *pwm; struct pwm_device *pwm;
/* flags in the third cell are optional */ /* period in the second cell and flags in the third cell are optional */
if (args->args_count < 2) if (args->args_count < 1)
return ERR_PTR(-EINVAL); return ERR_PTR(-EINVAL);
if (args->args[0] >= chip->npwm) if (args->args[0] >= chip->npwm)
@ -118,9 +118,10 @@ of_pwm_xlate_with_flags(struct pwm_chip *chip, const struct of_phandle_args *arg
if (IS_ERR(pwm)) if (IS_ERR(pwm))
return pwm; return pwm;
if (args->args_count > 1)
pwm->args.period = args->args[1]; pwm->args.period = args->args[1];
pwm->args.polarity = PWM_POLARITY_NORMAL;
pwm->args.polarity = PWM_POLARITY_NORMAL;
if (args->args_count > 2 && args->args[2] & PWM_POLARITY_INVERTED) if (args->args_count > 2 && args->args[2] & PWM_POLARITY_INVERTED)
pwm->args.polarity = PWM_POLARITY_INVERSED; pwm->args.polarity = PWM_POLARITY_INVERSED;
@ -133,18 +134,15 @@ of_pwm_single_xlate(struct pwm_chip *chip, const struct of_phandle_args *args)
{ {
struct pwm_device *pwm; struct pwm_device *pwm;
/* validate that one cell is specified, optionally with flags */
if (args->args_count != 1 && args->args_count != 2)
return ERR_PTR(-EINVAL);
pwm = pwm_request_from_chip(chip, 0, NULL); pwm = pwm_request_from_chip(chip, 0, NULL);
if (IS_ERR(pwm)) if (IS_ERR(pwm))
return pwm; return pwm;
if (args->args_count > 1)
pwm->args.period = args->args[0]; pwm->args.period = args->args[0];
pwm->args.polarity = PWM_POLARITY_NORMAL;
if (args->args_count == 2 && args->args[1] & PWM_POLARITY_INVERTED) pwm->args.polarity = PWM_POLARITY_NORMAL;
if (args->args_count > 1 && args->args[1] & PWM_POLARITY_INVERTED)
pwm->args.polarity = PWM_POLARITY_INVERSED; pwm->args.polarity = PWM_POLARITY_INVERSED;
return pwm; return pwm;