niansa-misc/linux
1
0
Fork 0
mirror of synced 2025-03-06 20:59:54 +01:00
Code Issues Projects Releases Packages Wiki Activity

amd-xgbe: Replace MII_ADDR_C45 with XGBE_ADDR_C45

Browse source 
The xgbe driver reuses MII_ADDR_C45 for its own purpose. The values
derived with it are never passed to phylib or a linux MDIO bus driver.
In order that MII_ADDR_C45 can be removed, add an XGBE specific

Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Michael Walle <michael@walle.cc>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
Andrew Lunn 2023-01-17 00:52:24 +01:00 • committed by Jakub Kicinski
parent 070f6186a2
commit 47e61593f3
2 changed files with 14 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
drivers/net/ethernet/amd/xgbe/xgbe-common.h
View file

@ -1699,20 +1699,21 @@ do { \
} while (0) } while (0)
/* Macros for building, reading or writing register values or bits /* Macros for building, reading or writing register values or bits
* using MDIO. Different from above because of the use of standardized * using MDIO.
* Linux include values. No shifting is performed with the bit
* operations, everything works on mask values.
*/ */
#define XGBE_ADDR_C45 BIT(30)
#define XMDIO_READ(_pdata, _mmd, _reg) \ #define XMDIO_READ(_pdata, _mmd, _reg) \
((_pdata)->hw_if.read_mmd_regs((_pdata), 0, \ ((_pdata)->hw_if.read_mmd_regs((_pdata), 0, \
MII_ADDR_C45 | (_mmd << 16) | ((_reg) & 0xffff))) XGBE_ADDR_C45 | (_mmd << 16) | ((_reg) & 0xffff)))
#define XMDIO_READ_BITS(_pdata, _mmd, _reg, _mask) \ #define XMDIO_READ_BITS(_pdata, _mmd, _reg, _mask) \
(XMDIO_READ((_pdata), _mmd, _reg) & _mask) (XMDIO_READ((_pdata), _mmd, _reg) & _mask)
#define XMDIO_WRITE(_pdata, _mmd, _reg, _val) \ #define XMDIO_WRITE(_pdata, _mmd, _reg, _val) \
((_pdata)->hw_if.write_mmd_regs((_pdata), 0, \ ((_pdata)->hw_if.write_mmd_regs((_pdata), 0, \
MII_ADDR_C45 | (_mmd << 16) | ((_reg) & 0xffff), (_val))) XGBE_ADDR_C45 | (_mmd << 16) | ((_reg) & 0xffff), (_val)))
#define XMDIO_WRITE_BITS(_pdata, _mmd, _reg, _mask, _val) \ #define XMDIO_WRITE_BITS(_pdata, _mmd, _reg, _mask, _val) \
do { \ do { \

16
drivers/net/ethernet/amd/xgbe/xgbe-dev.c
View file

@ -1150,8 +1150,8 @@ static int xgbe_read_mmd_regs_v2(struct xgbe_prv_data *pdata, int prtad,
unsigned int mmd_address, index, offset; unsigned int mmd_address, index, offset;
int mmd_data; int mmd_data;
if (mmd_reg & MII_ADDR_C45) if (mmd_reg & XGBE_ADDR_C45)
mmd_address = mmd_reg & ~MII_ADDR_C45; mmd_address = mmd_reg & ~XGBE_ADDR_C45;
else else
mmd_address = (pdata->mdio_mmd << 16) | (mmd_reg & 0xffff); mmd_address = (pdata->mdio_mmd << 16) | (mmd_reg & 0xffff);
@ -1182,8 +1182,8 @@ static void xgbe_write_mmd_regs_v2(struct xgbe_prv_data *pdata, int prtad,
unsigned long flags; unsigned long flags;
unsigned int mmd_address, index, offset; unsigned int mmd_address, index, offset;
if (mmd_reg & MII_ADDR_C45) if (mmd_reg & XGBE_ADDR_C45)
mmd_address = mmd_reg & ~MII_ADDR_C45; mmd_address = mmd_reg & ~XGBE_ADDR_C45;
else else
mmd_address = (pdata->mdio_mmd << 16) | (mmd_reg & 0xffff); mmd_address = (pdata->mdio_mmd << 16) | (mmd_reg & 0xffff);
@ -1213,8 +1213,8 @@ static int xgbe_read_mmd_regs_v1(struct xgbe_prv_data *pdata, int prtad,
unsigned int mmd_address; unsigned int mmd_address;
int mmd_data; int mmd_data;
if (mmd_reg & MII_ADDR_C45) if (mmd_reg & XGBE_ADDR_C45)
mmd_address = mmd_reg & ~MII_ADDR_C45; mmd_address = mmd_reg & ~XGBE_ADDR_C45;
else else
mmd_address = (pdata->mdio_mmd << 16) | (mmd_reg & 0xffff); mmd_address = (pdata->mdio_mmd << 16) | (mmd_reg & 0xffff);
@ -1241,8 +1241,8 @@ static void xgbe_write_mmd_regs_v1(struct xgbe_prv_data *pdata, int prtad,
unsigned int mmd_address; unsigned int mmd_address;
unsigned long flags; unsigned long flags;
if (mmd_reg & MII_ADDR_C45) if (mmd_reg & XGBE_ADDR_C45)
mmd_address = mmd_reg & ~MII_ADDR_C45; mmd_address = mmd_reg & ~XGBE_ADDR_C45;
else else
mmd_address = (pdata->mdio_mmd << 16) | (mmd_reg & 0xffff); mmd_address = (pdata->mdio_mmd << 16) | (mmd_reg & 0xffff);