niansa-misc/linux
1
0
Fork 0
mirror of synced 2025-03-06 20:59:54 +01:00
Code Issues Projects Releases Packages Wiki Activity

platform/surface: aggregator: move to use request_irq by IRQF_NO_AUTOEN flag

Browse source 
disable_irq() after request_irq() still has a time gap in which
interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will
disable IRQ auto-enable because of requesting.

this patch is made base on "add IRQF_NO_AUTOEN for request_irq" which
is being merged: https://lore.kernel.org/patchwork/patch/1388765/

Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com>
Link: https://lore.kernel.org/r/1617778852-26492-1-git-send-email-tiantao6@hisilicon.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
This commit is contained in:
Tian Tao 2021-04-07 15:00:52 +08:00 • committed by Hans de Goede
parent bee3ecfed0
commit 507cf5a2f1
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/platform/surface/aggregator/controller.c
View file

@ -2483,7 +2483,8 @@ int ssam_irq_setup(struct ssam_controller *ctrl)
* interrupt, and let the SAM resume callback during the controller * interrupt, and let the SAM resume callback during the controller
* resume process clear it. * resume process clear it.
*/ */
const int irqf = IRQF_SHARED | IRQF_ONESHOT | IRQF_TRIGGER_RISING; const int irqf = IRQF_SHARED | IRQF_ONESHOT |
IRQF_TRIGGER_RISING | IRQF_NO_AUTOEN;
gpiod = gpiod_get(dev, "ssam_wakeup-int", GPIOD_ASIS); gpiod = gpiod_get(dev, "ssam_wakeup-int", GPIOD_ASIS);
if (IS_ERR(gpiod)) if (IS_ERR(gpiod))
@ -2501,7 +2502,6 @@ int ssam_irq_setup(struct ssam_controller *ctrl)
return status; return status;
ctrl->irq.num = irq; ctrl->irq.num = irq;
disable_irq(ctrl->irq.num);
return 0; return 0;
} }