niansa-misc/linux
1
0
Fork 0
mirror of synced 2025-03-06 20:59:54 +01:00
Code Issues Projects Releases Packages Wiki Activity

xfs: detect empty attr leaf blocks in xfs_attr3_leaf_verify

Browse source 
xfs_repair flags these as a corruption error, so the verifier should
catch software bugs that result in empty leaf blocks being written
to disk, too.

Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Allison Henderson <allison.henderson@oracle.com>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Dave Chinner <david@fromorbit.com>
This commit is contained in:
Dave Chinner 2022-05-12 15:12:57 +10:00 • committed by Dave Chinner
parent fdaf1bb3ca
commit 51e6104fdb
1 changed files with 9 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
fs/xfs/libxfs/xfs_attr_leaf.c
View file

@ -310,6 +310,15 @@ xfs_attr3_leaf_verify(
if (fa) if (fa)
return fa; return fa;
/*
* Empty leaf blocks should never occur; they imply the existence of a
* software bug that needs fixing. xfs_repair also flags them as a
* corruption that needs fixing, so we should never let these go to
* disk.
*/
if (ichdr.count == 0)
return __this_address;
/* /*
* firstused is the block offset of the first name info structure. * firstused is the block offset of the first name info structure.
* Make sure it doesn't go off the block or crash into the header. * Make sure it doesn't go off the block or crash into the header.