niansa-misc/linux
1
0
Fork 0
mirror of synced 2025-03-06 20:59:54 +01:00
Code Issues Projects Releases Packages Wiki Activity

bus: imx-weim: improve error handling upon child probe-failure

Browse source 
Probe all children of the WEIM node, reporting any failures.  Report
failure from parsing of WEIM node itself if probes of all children fail.

Signed-off-by: Alison Chaiken <alison_chaiken@mentor.com>
Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
This commit is contained in:
Alison Chaiken 2015-02-18 23:24:10 -08:00 • committed by Shawn Guo
parent e654df7a1a
commit 52c47b6341
1 changed files with 7 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
drivers/bus/imx-weim.c
View file

@ -142,7 +142,7 @@ static int __init weim_parse_dt(struct platform_device *pdev,
&pdev->dev); &pdev->dev);
const struct imx_weim_devtype *devtype = of_id->data; const struct imx_weim_devtype *devtype = of_id->data;
struct device_node *child; struct device_node *child;
int ret; int ret, have_child = 0;
if (devtype == &imx50_weim_devtype) { if (devtype == &imx50_weim_devtype) {
ret = imx_weim_gpr_setup(pdev); ret = imx_weim_gpr_setup(pdev);
@ -155,13 +155,14 @@ static int __init weim_parse_dt(struct platform_device *pdev,
continue; continue;
ret = weim_timing_setup(child, base, devtype); ret = weim_timing_setup(child, base, devtype);
if (ret) { if (ret)
dev_err(&pdev->dev, "%s set timing failed.\n", dev_warn(&pdev->dev, "%s set timing failed.\n",
child->full_name); child->full_name);
return ret; else
} have_child = 1;
} }
if (have_child)
ret = of_platform_populate(pdev->dev.of_node, ret = of_platform_populate(pdev->dev.of_node,
of_default_bus_match_table, of_default_bus_match_table,
NULL, &pdev->dev); NULL, &pdev->dev);