niansa-misc/linux
1
0
Fork 0
mirror of synced 2025-03-06 20:59:54 +01:00
Code Issues Projects Releases Packages Wiki Activity

ipv6: sr: fix possible use-after-free and null-ptr-deref

Browse source 
The pernet operations structure for the subsystem must be registered
before registering the generic netlink family.

Fixes: 915d7e5e59 ("ipv6: sr: add code base for control plane support of SR-IPv6")
Signed-off-by: Vasiliy Kovalev <kovalev@altlinux.org>
Link: https://lore.kernel.org/r/20240215202717.29815-1-kovalev@altlinux.org
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
This commit is contained in:
Vasiliy Kovalev 2024-02-15 23:27:17 +03:00 • committed by Paolo Abeni
parent 40b9385dd8
commit 5559cea2d5
1 changed files with 11 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
net/ipv6/seg6.c
View file

@ -512,22 +512,24 @@ int __init seg6_init(void)
{ {
int err; int err;
err = genl_register_family(&seg6_genl_family); err = register_pernet_subsys(&ip6_segments_ops);
if (err) if (err)
goto out; goto out;
err = register_pernet_subsys(&ip6_segments_ops); err = genl_register_family(&seg6_genl_family);
if (err) if (err)
goto out_unregister_genl; goto out_unregister_pernet;
#ifdef CONFIG_IPV6_SEG6_LWTUNNEL #ifdef CONFIG_IPV6_SEG6_LWTUNNEL
err = seg6_iptunnel_init(); err = seg6_iptunnel_init();
if (err) if (err)
goto out_unregister_pernet; goto out_unregister_genl;
err = seg6_local_init(); err = seg6_local_init();
if (err) if (err) {
goto out_unregister_pernet; seg6_iptunnel_exit();
goto out_unregister_genl;
}
#endif #endif
#ifdef CONFIG_IPV6_SEG6_HMAC #ifdef CONFIG_IPV6_SEG6_HMAC
@ -548,11 +550,11 @@ out_unregister_iptun:
#endif #endif
#endif #endif
#ifdef CONFIG_IPV6_SEG6_LWTUNNEL #ifdef CONFIG_IPV6_SEG6_LWTUNNEL
out_unregister_pernet:
unregister_pernet_subsys(&ip6_segments_ops);
#endif
out_unregister_genl: out_unregister_genl:
genl_unregister_family(&seg6_genl_family); genl_unregister_family(&seg6_genl_family);
#endif
out_unregister_pernet:
unregister_pernet_subsys(&ip6_segments_ops);
goto out; goto out;
} }