dt-bindings: phy: brcm,ns-usb2-phy: bind just a PHY block
The old binding was covering the whole DMU block space (DMU block contains CRU block which contains USB PHY). It was a bad design, overkill and a non-generic solution. Northstar's USB 2.0 PHY is a small block (part of the CRU MFD) and binding should be designed to represent that properly. Rework the binding to map just PHY with the "reg" property and use syscon to reference shared register that controls block access. The old binding is deprecated now. Signed-off-by: Rafał Miłecki <rafal@milecki.pl> Reviewed-by: Rob Herring <robh@kernel.org> Link: https://lore.kernel.org/r/20210913080024.6951-2-zajec5@gmail.com Signed-off-by: Vinod Koul <vkoul@kernel.org>
This commit is contained in:
parent
0fd732f824
commit
55b9b74171
1 changed files with 19 additions and 6 deletions
|
@ -18,13 +18,21 @@ properties:
|
||||||
const: brcm,ns-usb2-phy
|
const: brcm,ns-usb2-phy
|
||||||
|
|
||||||
reg:
|
reg:
|
||||||
items:
|
anyOf:
|
||||||
- description: iomem address range of DMU (Device Management Unit)
|
- maxItems: 1
|
||||||
|
description: PHY control register
|
||||||
|
- maxItems: 1
|
||||||
|
description: iomem address range of DMU (Device Management Unit)
|
||||||
|
deprecated: true
|
||||||
|
|
||||||
reg-names:
|
reg-names:
|
||||||
items:
|
items:
|
||||||
- const: dmu
|
- const: dmu
|
||||||
|
|
||||||
|
brcm,syscon-clkset:
|
||||||
|
description: phandle to syscon for clkset register
|
||||||
|
$ref: /schemas/types.yaml#/definitions/phandle
|
||||||
|
|
||||||
clocks:
|
clocks:
|
||||||
items:
|
items:
|
||||||
- description: USB PHY reference clock
|
- description: USB PHY reference clock
|
||||||
|
@ -39,20 +47,25 @@ properties:
|
||||||
required:
|
required:
|
||||||
- compatible
|
- compatible
|
||||||
- reg
|
- reg
|
||||||
- reg-names
|
|
||||||
- clocks
|
- clocks
|
||||||
- clock-names
|
- clock-names
|
||||||
- "#phy-cells"
|
- "#phy-cells"
|
||||||
|
|
||||||
|
oneOf:
|
||||||
|
- required:
|
||||||
|
- brcm,syscon-clkset
|
||||||
|
- required:
|
||||||
|
- reg-names
|
||||||
|
|
||||||
additionalProperties: false
|
additionalProperties: false
|
||||||
|
|
||||||
examples:
|
examples:
|
||||||
- |
|
- |
|
||||||
#include <dt-bindings/clock/bcm-nsp.h>
|
#include <dt-bindings/clock/bcm-nsp.h>
|
||||||
phy@1800c000 {
|
phy@1800c164 {
|
||||||
compatible = "brcm,ns-usb2-phy";
|
compatible = "brcm,ns-usb2-phy";
|
||||||
reg = <0x1800c000 0x1000>;
|
reg = <0x1800c164 0x4>;
|
||||||
reg-names = "dmu";
|
brcm,syscon-clkset = <&clkset>;
|
||||||
clocks = <&genpll BCM_NSP_GENPLL_USB_PHY_REF_CLK>;
|
clocks = <&genpll BCM_NSP_GENPLL_USB_PHY_REF_CLK>;
|
||||||
clock-names = "phy-ref-clk";
|
clock-names = "phy-ref-clk";
|
||||||
#phy-cells = <0>;
|
#phy-cells = <0>;
|
||||||
|
|
Loading…
Add table
Reference in a new issue