niansa-misc/linux
1
0
Fork 0
mirror of synced 2025-03-06 20:59:54 +01:00
Code Issues Projects Releases Packages Wiki Activity

net: remove useless memset's in drivers get_stats64

Browse source 
In dev_get_stats() the statistic structure storage has already been
zeroed. Therefore network drivers do not need to call memset() again.

Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
stephen hemminger 2017-01-06 19:12:53 -08:00 • committed by David S. Miller
parent bc1f44709c
commit 5944701df9
3 changed files with 0 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
drivers/net/ethernet/apm/xgene/xgene_enet_main.c
View file

@ -1462,7 +1462,6 @@ static void xgene_enet_get_stats64(
struct xgene_enet_desc_ring *ring; struct xgene_enet_desc_ring *ring;
int i; int i;
memset(stats, 0, sizeof(struct rtnl_link_stats64));
for (i = 0; i < pdata->txq_cnt; i++) { for (i = 0; i < pdata->txq_cnt; i++) {
ring = pdata->tx_ring[i]; ring = pdata->tx_ring[i];
if (ring) { if (ring) {

2
drivers/net/ethernet/broadcom/bnxt/bnxt.c
View file

@ -5885,8 +5885,6 @@ bnxt_get_stats64(struct net_device *dev, struct rtnl_link_stats64 *stats)
u32 i; u32 i;
struct bnxt *bp = netdev_priv(dev); struct bnxt *bp = netdev_priv(dev);
memset(stats, 0, sizeof(struct rtnl_link_stats64));
if (!bp->bnapi) if (!bp->bnapi)
return; return;

1
drivers/net/ethernet/intel/e1000e/netdev.c
View file

@ -5925,7 +5925,6 @@ void e1000e_get_stats64(struct net_device *netdev,
{ {
struct e1000_adapter *adapter = netdev_priv(netdev); struct e1000_adapter *adapter = netdev_priv(netdev);
memset(stats, 0, sizeof(struct rtnl_link_stats64));
spin_lock(&adapter->stats64_lock); spin_lock(&adapter->stats64_lock);
e1000e_update_stats(adapter); e1000e_update_stats(adapter);
/* Fill out the OS statistics structure */ /* Fill out the OS statistics structure */