niansa-misc/linux
1
0
Fork 0
mirror of synced 2025-03-06 20:59:54 +01:00
Code Issues Projects Releases Packages Wiki Activity

tty/n_gsm.c: fix a memory leak in gsmld_open

Browse source 
If gsmld_attach_gsm fails, the gsm is not used anymore.
tty core will not call gsmld_close to do the cleanup work.
tty core just restore to the tty old ldisc.
That always causes memory leak.

Signed-off-by: xinhui.pan <xinhuiX.pan@intel.com>
Reported-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
xinhui.pan 2014-07-28 16:14:52 +08:00 • committed by Greg Kroah-Hartman
parent 8368d6a2b7
commit 5a64096700
1 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
drivers/tty/n_gsm.c
View file

@ -2366,6 +2366,7 @@ static void gsmld_close(struct tty_struct *tty)
static int gsmld_open(struct tty_struct *tty) static int gsmld_open(struct tty_struct *tty)
{ {
struct gsm_mux *gsm; struct gsm_mux *gsm;
int ret;
if (tty->ops->write == NULL) if (tty->ops->write == NULL)
return -EINVAL; return -EINVAL;
@ -2380,7 +2381,13 @@ static int gsmld_open(struct tty_struct *tty)
/* Attach the initial passive connection */ /* Attach the initial passive connection */
gsm->encoding = 1; gsm->encoding = 1;
return gsmld_attach_gsm(tty, gsm);
ret = gsmld_attach_gsm(tty, gsm);
if (ret != 0) {
gsm_cleanup_mux(gsm);
mux_put(gsm);
}
return ret;
} }
/** /**