niansa-misc/linux
1
0
Fork 0
mirror of synced 2025-03-06 20:59:54 +01:00
Code Issues Projects Releases Packages Wiki Activity

NFS: Fix up a sparse warning

Browse source 
sparse is warning about an incorrect RCU dereference.
fs/nfs/dir.c:2965:56: warning: incorrect type in argument 1 (different address spaces)
fs/nfs/dir.c:2965:56:    expected struct cred const *
fs/nfs/dir.c:2965:56:    got struct cred const [noderef] __rcu *const cred

Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
This commit is contained in:
Trond Myklebust 2023-01-01 20:17:23 -05:00
parent 029085b894
commit 5e9a7b9c2e
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
fs/nfs/dir.c
View file

@ -2957,12 +2957,14 @@ static u64 nfs_access_login_time(const struct task_struct *task,
const struct cred *cred) const struct cred *cred)
{ {
const struct task_struct *parent; const struct task_struct *parent;
const struct cred *pcred;
u64 ret; u64 ret;
rcu_read_lock(); rcu_read_lock();
for (;;) { for (;;) {
parent = rcu_dereference(task->real_parent); parent = rcu_dereference(task->real_parent);
if (parent == task || cred_fscmp(parent->cred, cred) != 0) pcred = rcu_dereference(parent->cred);
if (parent == task || cred_fscmp(pcred, cred) != 0)
break; break;
task = parent; task = parent;
} }