niansa-misc/linux
1
0
Fork 0
mirror of synced 2025-03-06 20:59:54 +01:00
Code Issues Projects Releases Packages Wiki Activity

mtd: rawnand: cadence: fix unchecked dereference

Browse source 
Add NULL check before variable dereference to fix static checker warning.

Fixes: d76d22b509 ("mtd: rawnand: cadence: use dma_map_resource for sdma address")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/all/e448a22c-bada-448d-9167-7af71305130d@stanley.mountain/
Signed-off-by: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
This commit is contained in:
Niravkumar L Rabara 2025-02-16 11:15:36 +08:00 • committed by Miquel Raynal
parent 41758630dd
commit 60255f3704
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
drivers/mtd/nand/raw/cadence-nand-controller.c
View file

@ -2972,8 +2972,10 @@ free_buf_desc:
static void cadence_nand_remove(struct cdns_nand_ctrl *cdns_ctrl) static void cadence_nand_remove(struct cdns_nand_ctrl *cdns_ctrl)
{ {
cadence_nand_chips_cleanup(cdns_ctrl); cadence_nand_chips_cleanup(cdns_ctrl);
dma_unmap_resource(cdns_ctrl->dmac->device->dev, cdns_ctrl->io.iova_dma, if (cdns_ctrl->dmac)
cdns_ctrl->io.size, DMA_BIDIRECTIONAL, 0); dma_unmap_resource(cdns_ctrl->dmac->device->dev,
cdns_ctrl->io.iova_dma, cdns_ctrl->io.size,
DMA_BIDIRECTIONAL, 0);
cadence_nand_irq_cleanup(cdns_ctrl->irq, cdns_ctrl); cadence_nand_irq_cleanup(cdns_ctrl->irq, cdns_ctrl);
kfree(cdns_ctrl->buf); kfree(cdns_ctrl->buf);
dma_free_coherent(cdns_ctrl->dev, sizeof(struct cadence_nand_cdma_desc), dma_free_coherent(cdns_ctrl->dev, sizeof(struct cadence_nand_cdma_desc),