niansa-misc/linux
1
0
Fork 0
mirror of synced 2025-03-06 20:59:54 +01:00
Code Issues Projects Releases Packages Wiki Activity

ALSA: echoaudio: Prevent races in calls to set_audio_format()

Browse source 
The function uses chip->comm_page which needs locking against
other use at the same time.

Signed-off-by: Mark Hills <mark@xwax.org>
Link: https://lore.kernel.org/r/20200708101848.3457-3-mark@xwax.org
Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Mark Hills 2020-07-08 11:18:46 +01:00 • committed by Takashi Iwai
parent 027c70021b
commit 6c33125448
1 changed files with 14 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
sound/pci/echoaudio/echoaudio.c
View file

@ -711,9 +711,22 @@ static int pcm_prepare(struct snd_pcm_substream *substream)
if (snd_BUG_ON(pipe_index >= px_num(chip))) if (snd_BUG_ON(pipe_index >= px_num(chip)))
return -EINVAL; return -EINVAL;
if (snd_BUG_ON(!is_pipe_allocated(chip, pipe_index)))
/*
* We passed checks we can do independently; now take
* exclusive control
*/
spin_lock_irq(&chip->lock);
if (snd_BUG_ON(!is_pipe_allocated(chip, pipe_index))) {
spin_unlock(&chip->lock);
return -EINVAL; return -EINVAL;
}
set_audio_format(chip, pipe_index, &format); set_audio_format(chip, pipe_index, &format);
spin_unlock_irq(&chip->lock);
return 0; return 0;
} }