niansa-misc/linux
1
0
Fork 0
mirror of synced 2025-03-06 20:59:54 +01:00
Code Issues Projects Releases Packages Wiki Activity

ASoC: simple-card: fixup cpu_dai_name clear case

Browse source 
f687d900d3
(ASoC: simple-card: cpu_dai_name creates confusion when DT case)
cleared cpu_dai_name for caring fmt_single_name case,
and
179949bc04
(ASoC: simple-card: remove dai_link->cpu_dai_name when DT)
cared multi dai-link case.
but, cpu_dai_name matching is required when fmt_multiple_name was used

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Tested-by: Jean-Francois Moine <moinejf@free.fr>
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Kuninori Morimoto 2014-09-02 04:05:30 -07:00 • committed by Mark Brown
parent a44a750e52
commit 7c7b9cf53d
1 changed files with 19 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
sound/soc/generic/simple-card.c
View file

@ -112,8 +112,10 @@ static int
asoc_simple_card_sub_parse_of(struct device_node *np, asoc_simple_card_sub_parse_of(struct device_node *np,
struct asoc_simple_dai *dai, struct asoc_simple_dai *dai,
struct device_node **p_node, struct device_node **p_node,
const char **name) const char **name,
int *args_count)
{ {
struct of_phandle_args args;
struct device_node *node; struct device_node *node;
struct clk *clk; struct clk *clk;
u32 val; u32 val;
@ -123,10 +125,15 @@ asoc_simple_card_sub_parse_of(struct device_node *np,
* get node via "sound-dai = <&phandle port>" * get node via "sound-dai = <&phandle port>"
* it will be used as xxx_of_node on soc_bind_dai_link() * it will be used as xxx_of_node on soc_bind_dai_link()
*/ */
node = of_parse_phandle(np, "sound-dai", 0); ret = of_parse_phandle_with_args(np, "sound-dai",
if (!node) "#sound-dai-cells", 0, &args);
return -ENODEV; if (ret)
*p_node = node; return ret;
*p_node = args.np;
if (args_count)
*args_count = args.args_count;
/* get dai->name */ /* get dai->name */
ret = snd_soc_of_get_dai_name(np, name); ret = snd_soc_of_get_dai_name(np, name);
@ -176,7 +183,7 @@ static int asoc_simple_card_dai_link_of(struct device_node *node,
char *name; char *name;
char prop[128]; char prop[128];
char *prefix = ""; char *prefix = "";
int ret; int ret, cpu_args;
if (is_top_level_node) if (is_top_level_node)
prefix = "simple-audio-card,"; prefix = "simple-audio-card,";
@ -195,7 +202,8 @@ static int asoc_simple_card_dai_link_of(struct device_node *node,
ret = asoc_simple_card_sub_parse_of(np, &dai_props->cpu_dai, ret = asoc_simple_card_sub_parse_of(np, &dai_props->cpu_dai,
&dai_link->cpu_of_node, &dai_link->cpu_of_node,
&dai_link->cpu_dai_name); &dai_link->cpu_dai_name,
&cpu_args);
if (ret < 0) if (ret < 0)
goto dai_link_of_err; goto dai_link_of_err;
@ -226,7 +234,7 @@ static int asoc_simple_card_dai_link_of(struct device_node *node,
ret = asoc_simple_card_sub_parse_of(np, &dai_props->codec_dai, ret = asoc_simple_card_sub_parse_of(np, &dai_props->codec_dai,
&dai_link->codec_of_node, &dai_link->codec_of_node,
&dai_link->codec_dai_name); &dai_link->codec_dai_name, NULL);
if (ret < 0) if (ret < 0)
goto dai_link_of_err; goto dai_link_of_err;
@ -290,12 +298,13 @@ static int asoc_simple_card_dai_link_of(struct device_node *node,
* soc_bind_dai_link() will check cpu name * soc_bind_dai_link() will check cpu name
* after of_node matching if dai_link has cpu_dai_name. * after of_node matching if dai_link has cpu_dai_name.
* but, it will never match if name was created by fmt_single_name() * but, it will never match if name was created by fmt_single_name()
* remove cpu_dai_name to escape name matching. * remove cpu_dai_name if cpu_args was 0.
* see * see
* fmt_single_name() * fmt_single_name()
* fmt_multiple_name() * fmt_multiple_name()
*/ */
dai_link->cpu_dai_name = NULL; if (!cpu_args)
dai_link->cpu_dai_name = NULL;
dai_link_of_err: dai_link_of_err:
if (np) if (np)