niansa-misc/linux
1
0
Fork 0
mirror of synced 2025-03-06 20:59:54 +01:00
Code Issues Projects Releases Packages Wiki Activity

net: arc_emac: Make use of the helper function dev_err_probe()

Browse source 
When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
And using dev_err_probe() can reduce code size, and simplify the code.

Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Cai Huoqing 2021-09-15 22:57:41 +08:00 • committed by David S. Miller
parent 5706383b30
commit 95b5fc03c1
1 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
drivers/net/ethernet/arc/emac_mdio.c
View file

@ -151,10 +151,9 @@ int arc_mdio_probe(struct arc_emac_priv *priv)
data->reset_gpio = devm_gpiod_get_optional(priv->dev, "phy-reset", data->reset_gpio = devm_gpiod_get_optional(priv->dev, "phy-reset",
GPIOD_OUT_LOW); GPIOD_OUT_LOW);
if (IS_ERR(data->reset_gpio)) { if (IS_ERR(data->reset_gpio)) {
error = PTR_ERR(data->reset_gpio);
dev_err(priv->dev, "Failed to request gpio: %d\n", error);
mdiobus_free(bus); mdiobus_free(bus);
return error; return dev_err_probe(priv->dev, PTR_ERR(data->reset_gpio),
"Failed to request gpio\n");
} }
of_property_read_u32(np, "phy-reset-duration", &data->msec); of_property_read_u32(np, "phy-reset-duration", &data->msec);
@ -166,9 +165,9 @@ int arc_mdio_probe(struct arc_emac_priv *priv)
error = of_mdiobus_register(bus, priv->dev->of_node); error = of_mdiobus_register(bus, priv->dev->of_node);
if (error) { if (error) {
dev_err(priv->dev, "cannot register MDIO bus %s\n", bus->name);
mdiobus_free(bus); mdiobus_free(bus);
return error; return dev_err_probe(priv->dev, error,
"cannot register MDIO bus %s\n", bus->name);
} }
return 0; return 0;