niansa-misc/linux
1
0
Fork 0
mirror of synced 2025-03-06 20:59:54 +01:00
Code Issues Projects Releases Packages Wiki Activity

regulator: ti-abb: Make use of the helper function devm_ioremap related

Browse source 
Use the devm_platform_ioremap_resource_byname() helper instead of
calling platform_get_resource_byname() and devm_ioremap/devm_ioremap_resource()
separately

Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
Link: https://lore.kernel.org/r/20210908105745.1984-1-caihuoqing@baidu.com
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Cai Huoqing 2021-09-08 18:57:44 +08:00 • committed by Mark Brown
parent c33e65cbbd
commit b36c6b1887
No known key found for this signature in database
GPG key ID: 24D68B725D5487D0
1 changed files with 6 additions and 25 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

31
drivers/regulator/ti-abb-regulator.c
View file

@ -725,9 +725,7 @@ static int ti_abb_probe(struct platform_device *pdev)
/* Map ABB resources */ /* Map ABB resources */
if (abb->regs->setup_off || abb->regs->control_off) { if (abb->regs->setup_off || abb->regs->control_off) {
pname = "base-address"; abb->base = devm_platform_ioremap_resource_byname(pdev, "base-address");
res = platform_get_resource_byname(pdev, IORESOURCE_MEM, pname);
abb->base = devm_ioremap_resource(dev, res);
if (IS_ERR(abb->base)) if (IS_ERR(abb->base))
return PTR_ERR(abb->base); return PTR_ERR(abb->base);
@ -735,35 +733,18 @@ static int ti_abb_probe(struct platform_device *pdev)
abb->control_reg = abb->base + abb->regs->control_off; abb->control_reg = abb->base + abb->regs->control_off;
} else { } else {
pname = "control-address"; abb->control_reg = devm_platform_ioremap_resource_byname(pdev, "control-address");
res = platform_get_resource_byname(pdev, IORESOURCE_MEM, pname);
abb->control_reg = devm_ioremap_resource(dev, res);
if (IS_ERR(abb->control_reg)) if (IS_ERR(abb->control_reg))
return PTR_ERR(abb->control_reg); return PTR_ERR(abb->control_reg);
pname = "setup-address"; abb->setup_reg = devm_platform_ioremap_resource_byname(pdev, "setup-address");
res = platform_get_resource_byname(pdev, IORESOURCE_MEM, pname);
abb->setup_reg = devm_ioremap_resource(dev, res);
if (IS_ERR(abb->setup_reg)) if (IS_ERR(abb->setup_reg))
return PTR_ERR(abb->setup_reg); return PTR_ERR(abb->setup_reg);
} }
pname = "int-address"; abb->int_base = devm_platform_ioremap_resource_byname(pdev, "int-address");
res = platform_get_resource_byname(pdev, IORESOURCE_MEM, pname); if (IS_ERR(abb->int_base))
if (!res) { return PTR_ERR(abb->int_base);
dev_err(dev, "Missing '%s' IO resource\n", pname);
return -ENODEV;
}
/*
* We may have shared interrupt register offsets which are
* write-1-to-clear between domains ensuring exclusivity.
*/
abb->int_base = devm_ioremap(dev, res->start,
resource_size(res));
if (!abb->int_base) {
dev_err(dev, "Unable to map '%s'\n", pname);
return -ENOMEM;
}
/* Map Optional resources */ /* Map Optional resources */
pname = "efuse-address"; pname = "efuse-address";