niansa-misc/linux
1
0
Fork 0
mirror of synced 2025-03-06 20:59:54 +01:00
Code Issues Projects Releases Packages Wiki Activity

selftest: fib_tests: Always cleanup before exit

Browse source 
Usage of `set -e` before executing a command causes immediate exit
on failure, without cleanup up the resources allocated at setup.
This can affect the next tests that use the same resources,
leading to a chain of failures.

A simple fix is to always call cleanup function when the script exists.
This approach is already used by other existing tests.

Fixes: 1056691b26 ("selftests: fib_tests: Make test results more verbose")
Signed-off-by: Roxana Nicolescu <roxana.nicolescu@canonical.com>
Link: https://lore.kernel.org/r/20230220110400.26737-2-roxana.nicolescu@canonical.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
This commit is contained in:
Roxana Nicolescu 2023-02-20 12:04:00 +01:00 • committed by Paolo Abeni
parent 3a70e0d4c9
commit b60417a9f2
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
tools/testing/selftests/net/fib_tests.sh
View file

@ -2065,6 +2065,8 @@ EOF
################################################################################
# main
trap cleanup EXIT
while getopts :t:pPhv o
do
case $o in