niansa-misc/linux
1
0
Fork 0
mirror of synced 2025-03-06 20:59:54 +01:00
Code Issues Projects Releases Packages Wiki Activity

soundwire: stream: only prepare stream when it is configured.

Browse source 
We don't need to prepare the stream again if the stream is already
prepared.

sdw_prepare_stream() could be called multiple times without calling
sdw_deprepare_stream(). We call sdw_prepare_stream() in the prepare
dai ops and sdw_deprepare_stream() in the hw_free dai ops. If an xrun
happens, sdw_prepare_stream() will be called but
sdw_deprepare_stream() will not, which results in an imbalance and an
invalid total bandwidth.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Link: https://lore.kernel.org/r/20200114235227.14502-3-pierre-louis.bossart@linux.intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
This commit is contained in:
Bard Liao 2020-01-14 17:52:24 -06:00 • committed by Vinod Koul
parent 5952880771
commit c32464c939
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
drivers/soundwire/stream.c
View file

@ -1544,7 +1544,7 @@ restore_params:
*/ */
int sdw_prepare_stream(struct sdw_stream_runtime *stream) int sdw_prepare_stream(struct sdw_stream_runtime *stream)
{ {
int ret = 0; int ret;
if (!stream) { if (!stream) {
pr_err("SoundWire: Handle not found for stream\n"); pr_err("SoundWire: Handle not found for stream\n");
@ -1553,6 +1553,11 @@ int sdw_prepare_stream(struct sdw_stream_runtime *stream)
sdw_acquire_bus_lock(stream); sdw_acquire_bus_lock(stream);
if (stream->state == SDW_STREAM_PREPARED) {
ret = 0;
goto state_err;
}
if (stream->state != SDW_STREAM_CONFIGURED && if (stream->state != SDW_STREAM_CONFIGURED &&
stream->state != SDW_STREAM_DEPREPARED && stream->state != SDW_STREAM_DEPREPARED &&
stream->state != SDW_STREAM_DISABLED) { stream->state != SDW_STREAM_DISABLED) {