niansa-misc/linux
1
0
Fork 0
mirror of synced 2025-03-06 20:59:54 +01:00
Code Issues Projects Releases Packages Wiki Activity

usb: phy: msm: reset controller is mandatory now

Browse source 
Commit a273454341 "usb: phy: msm: Use reset framework for LINK
and PHY resets" introduced a mandatory call to reset_control_get
into the msm usb phy driver, which means we have to add a Kconfig
dependency on the API to avoid this build error:

phy/phy-msm-usb.c: In function 'msm_otg_read_dt':
phy/phy-msm-usb.c:1461:2: error: implicit declaration of function 'devm_reset_control_get' [-Werror=implicit-function-declaration]
  motg->link_rst = devm_reset_control_get(&pdev->dev, "link");
  ^

Since the usb-ehci-msm driver currently selects the OTG driver,
we could still get a broken dependency here. To solve that,
this patch also removes the 'select', which turns out to be
unnecessary.

Reviewed-by: Ivan T. Ivanov <iivanov@mm-sol.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Felipe Balbi <balbi@ti.com>
This commit is contained in:
Arnd Bergmann 2014-05-13 21:46:52 +02:00 • committed by Felipe Balbi
parent a8d191c8bb
commit c5ab571f81
2 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
drivers/usb/host/Kconfig
View file

@ -170,7 +170,6 @@ config USB_EHCI_MSM
tristate "Support for Qualcomm QSD/MSM on-chip EHCI USB controller" tristate "Support for Qualcomm QSD/MSM on-chip EHCI USB controller"
depends on ARCH_MSM depends on ARCH_MSM
select USB_EHCI_ROOT_HUB_TT select USB_EHCI_ROOT_HUB_TT
select USB_MSM_OTG
---help--- ---help---
Enables support for the USB Host controller present on the Enables support for the USB Host controller present on the
Qualcomm chipsets. Root Hub has inbuilt TT. Qualcomm chipsets. Root Hub has inbuilt TT.

1
drivers/usb/phy/Kconfig
View file

@ -173,6 +173,7 @@ config USB_ISP1301
config USB_MSM_OTG config USB_MSM_OTG
tristate "Qualcomm on-chip USB OTG controller support" tristate "Qualcomm on-chip USB OTG controller support"
depends on (USB || USB_GADGET) && (ARCH_MSM || ARCH_QCOM || COMPILE_TEST) depends on (USB || USB_GADGET) && (ARCH_MSM || ARCH_QCOM || COMPILE_TEST)
depends on RESET_CONTROLLER
select USB_PHY select USB_PHY
help help
Enable this to support the USB OTG transceiver on Qualcomm chips. It Enable this to support the USB OTG transceiver on Qualcomm chips. It