niansa-misc/linux
1
0
Fork 0
mirror of synced 2025-03-06 20:59:54 +01:00
Code Issues Projects Releases Packages Wiki Activity

soundwire: Remove cdns_master_ops

Browse source 
There can be instances where drivers using Cadence IP might want
to set sdw_master_ops differently per instance of it's use, so
remove the cdns_master_ops and export the APIs.

Signed-off-by: Shreyas NC <shreyas.nc@intel.com>
Signed-off-by: Vinod Koul <vkoul@kernel.org>
This commit is contained in:
Shreyas NC 2018-04-26 18:38:43 +05:30 • committed by Vinod Koul
parent 97349b6051
commit c91605f489
3 changed files with 23 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
drivers/soundwire/cadence_master.c
View file

@ -396,7 +396,7 @@ static int cdns_prep_msg(struct sdw_cdns *cdns, struct sdw_msg *msg, int *cmd)
return 0; return 0;
} }
static enum sdw_command_response enum sdw_command_response
cdns_xfer_msg(struct sdw_bus *bus, struct sdw_msg *msg) cdns_xfer_msg(struct sdw_bus *bus, struct sdw_msg *msg)
{ {
struct sdw_cdns *cdns = bus_to_cdns(bus); struct sdw_cdns *cdns = bus_to_cdns(bus);
@ -422,8 +422,9 @@ cdns_xfer_msg(struct sdw_bus *bus, struct sdw_msg *msg)
exit: exit:
return ret; return ret;
} }
EXPORT_SYMBOL(cdns_xfer_msg);
static enum sdw_command_response enum sdw_command_response
cdns_xfer_msg_defer(struct sdw_bus *bus, cdns_xfer_msg_defer(struct sdw_bus *bus,
struct sdw_msg *msg, struct sdw_defer *defer) struct sdw_msg *msg, struct sdw_defer *defer)
{ {
@ -443,8 +444,9 @@ cdns_xfer_msg_defer(struct sdw_bus *bus,
return _cdns_xfer_msg(cdns, msg, cmd, 0, msg->len, true); return _cdns_xfer_msg(cdns, msg, cmd, 0, msg->len, true);
} }
EXPORT_SYMBOL(cdns_xfer_msg_defer);
static enum sdw_command_response enum sdw_command_response
cdns_reset_page_addr(struct sdw_bus *bus, unsigned int dev_num) cdns_reset_page_addr(struct sdw_bus *bus, unsigned int dev_num)
{ {
struct sdw_cdns *cdns = bus_to_cdns(bus); struct sdw_cdns *cdns = bus_to_cdns(bus);
@ -456,6 +458,7 @@ cdns_reset_page_addr(struct sdw_bus *bus, unsigned int dev_num)
return cdns_program_scp_addr(cdns, &msg); return cdns_program_scp_addr(cdns, &msg);
} }
EXPORT_SYMBOL(cdns_reset_page_addr);
/* /*
* IRQ handling * IRQ handling
@ -727,14 +730,6 @@ int sdw_cdns_init(struct sdw_cdns *cdns)
} }
EXPORT_SYMBOL(sdw_cdns_init); EXPORT_SYMBOL(sdw_cdns_init);
struct sdw_master_ops sdw_cdns_master_ops = {
.read_prop = sdw_master_read_prop,
.xfer_msg = cdns_xfer_msg,
.xfer_msg_defer = cdns_xfer_msg_defer,
.reset_page_addr = cdns_reset_page_addr,
};
EXPORT_SYMBOL(sdw_cdns_master_ops);
/** /**
* sdw_cdns_probe() - Cadence probe routine * sdw_cdns_probe() - Cadence probe routine
* @cdns: Cadence instance * @cdns: Cadence instance

8
drivers/soundwire/cadence_master.h
View file

@ -44,5 +44,13 @@ irqreturn_t sdw_cdns_thread(int irq, void *dev_id);
int sdw_cdns_init(struct sdw_cdns *cdns); int sdw_cdns_init(struct sdw_cdns *cdns);
int sdw_cdns_enable_interrupt(struct sdw_cdns *cdns); int sdw_cdns_enable_interrupt(struct sdw_cdns *cdns);
enum sdw_command_response
cdns_xfer_msg(struct sdw_bus *bus, struct sdw_msg *msg);
enum sdw_command_response
cdns_xfer_msg_defer(struct sdw_bus *bus,
struct sdw_msg *msg, struct sdw_defer *defer);
enum sdw_command_response
cdns_reset_page_addr(struct sdw_bus *bus, unsigned int dev_num);
#endif /* __SDW_CADENCE_H */ #endif /* __SDW_CADENCE_H */

11
drivers/soundwire/intel.c
View file

@ -252,6 +252,13 @@ static int intel_prop_read(struct sdw_bus *bus)
return 0; return 0;
} }
static struct sdw_master_ops sdw_intel_ops = {
.read_prop = sdw_master_read_prop,
.xfer_msg = cdns_xfer_msg,
.xfer_msg_defer = cdns_xfer_msg_defer,
.reset_page_addr = cdns_reset_page_addr,
};
/* /*
* probe and init * probe and init
*/ */
@ -276,8 +283,8 @@ static int intel_probe(struct platform_device *pdev)
sdw_cdns_probe(&sdw->cdns); sdw_cdns_probe(&sdw->cdns);
/* Set property read ops */ /* Set property read ops */
sdw_cdns_master_ops.read_prop = intel_prop_read; sdw_intel_ops.read_prop = intel_prop_read;
sdw->cdns.bus.ops = &sdw_cdns_master_ops; sdw->cdns.bus.ops = &sdw_intel_ops;
platform_set_drvdata(pdev, sdw); platform_set_drvdata(pdev, sdw);