niansa-misc/linux
1
0
Fork 0
mirror of synced 2025-03-06 20:59:54 +01:00
Code Issues Projects Releases Packages Wiki Activity

efivarfs: Defer PM notifier registration until .fill_super

Browse source 
syzbot reports an issue that turns out to be caused by the fact that the
efivarfs PM notifier may be invoked before the efivarfs_fs_info::sb
field is populated, resulting in a NULL deference.

So defer the registration until efivarfs_fill_super() is invoked.

Reported-by: syzbot+00d13e505ef530a45100@syzkaller.appspotmail.com
Tested-by: syzbot+00d13e505ef530a45100@syzkaller.appspotmail.com
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
This commit is contained in:
Ard Biesheuvel 2025-02-23 16:48:54 +01:00
parent d6a2d02aa0
commit cb6ae457bc
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
fs/efivarfs/super.c
View file

@ -367,6 +367,8 @@ static int efivarfs_fill_super(struct super_block *sb, struct fs_context *fc)
if (err) if (err)
return err; return err;
register_pm_notifier(&sfi->pm_nb);
return efivar_init(efivarfs_callback, sb, true); return efivar_init(efivarfs_callback, sb, true);
} }
@ -552,7 +554,6 @@ static int efivarfs_init_fs_context(struct fs_context *fc)
sfi->pm_nb.notifier_call = efivarfs_pm_notify; sfi->pm_nb.notifier_call = efivarfs_pm_notify;
sfi->pm_nb.priority = 0; sfi->pm_nb.priority = 0;
register_pm_notifier(&sfi->pm_nb);
return 0; return 0;
} }