niansa-misc/linux
1
0
Fork 0
mirror of synced 2025-03-06 20:59:54 +01:00
Code Issues Projects Releases Packages Wiki Activity

usb: typec: ucsi: Never send a lone connector change ack

Browse source 
Some PPM implementation do not like UCSI_ACK_CONNECTOR_CHANGE
without UCSI_ACK_COMMAND_COMPLETE. Moreover, doing this is racy
as it requires sending two UCSI_ACK_CC_CI commands in a row and
the second one will be started with UCSI_CCI_ACK_COMPLETE already
set in CCI.

Bundle the UCSI_ACK_CONNECTOR_CHANGE with the UCSI_ACK_COMMAND_COMPLETE
for the UCSI_GET_CONNECTOR_STATUS command that is sent while
handling a connector change event.

Signed-off-by: Christian A. Ehrhardt <lk@c--e.de>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Tested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/20240327224554.1772525-3-lk@c--e.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Christian A. Ehrhardt 2024-03-27 23:45:53 +01:00 • committed by Greg Kroah-Hartman
parent f3031f9b39
commit de52aca4d9
1 changed files with 21 additions and 27 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

46
drivers/usb/typec/ucsi/ucsi.c
View file

@ -49,22 +49,16 @@ static int ucsi_read_message_in(struct ucsi *ucsi, void *buf,
return ucsi->ops->read(ucsi, UCSI_MESSAGE_IN, buf, buf_size); return ucsi->ops->read(ucsi, UCSI_MESSAGE_IN, buf, buf_size);
} }
static int ucsi_acknowledge_command(struct ucsi *ucsi) static int ucsi_acknowledge(struct ucsi *ucsi, bool conn_ack)
{ {
u64 ctrl; u64 ctrl;
ctrl = UCSI_ACK_CC_CI; ctrl = UCSI_ACK_CC_CI;
ctrl |= UCSI_ACK_COMMAND_COMPLETE; ctrl |= UCSI_ACK_COMMAND_COMPLETE;
if (conn_ack) {
return ucsi->ops->sync_write(ucsi, UCSI_CONTROL, &ctrl, sizeof(ctrl)); clear_bit(EVENT_PENDING, &ucsi->flags);
}
static int ucsi_acknowledge_connector_change(struct ucsi *ucsi)
{
u64 ctrl;
ctrl = UCSI_ACK_CC_CI;
ctrl |= UCSI_ACK_CONNECTOR_CHANGE; ctrl |= UCSI_ACK_CONNECTOR_CHANGE;
}
return ucsi->ops->sync_write(ucsi, UCSI_CONTROL, &ctrl, sizeof(ctrl)); return ucsi->ops->sync_write(ucsi, UCSI_CONTROL, &ctrl, sizeof(ctrl));
} }
@ -77,7 +71,7 @@ static int ucsi_read_error(struct ucsi *ucsi)
int ret; int ret;
/* Acknowledge the command that failed */ /* Acknowledge the command that failed */
ret = ucsi_acknowledge_command(ucsi); ret = ucsi_acknowledge(ucsi, false);
if (ret) if (ret)
return ret; return ret;
@ -89,7 +83,7 @@ static int ucsi_read_error(struct ucsi *ucsi)
if (ret) if (ret)
return ret; return ret;
ret = ucsi_acknowledge_command(ucsi); ret = ucsi_acknowledge(ucsi, false);
if (ret) if (ret)
return ret; return ret;
@ -152,7 +146,7 @@ static int ucsi_exec_command(struct ucsi *ucsi, u64 cmd)
return -EIO; return -EIO;
if (cci & UCSI_CCI_NOT_SUPPORTED) { if (cci & UCSI_CCI_NOT_SUPPORTED) {
if (ucsi_acknowledge_command(ucsi) < 0) if (ucsi_acknowledge(ucsi, false) < 0)
dev_err(ucsi->dev, dev_err(ucsi->dev,
"ACK of unsupported command failed\n"); "ACK of unsupported command failed\n");
return -EOPNOTSUPP; return -EOPNOTSUPP;
@ -165,15 +159,15 @@ static int ucsi_exec_command(struct ucsi *ucsi, u64 cmd)
} }
if (cmd == UCSI_CANCEL && cci & UCSI_CCI_CANCEL_COMPLETE) { if (cmd == UCSI_CANCEL && cci & UCSI_CCI_CANCEL_COMPLETE) {
ret = ucsi_acknowledge_command(ucsi); ret = ucsi_acknowledge(ucsi, false);
return ret ? ret : -EBUSY; return ret ? ret : -EBUSY;
} }
return UCSI_CCI_LENGTH(cci); return UCSI_CCI_LENGTH(cci);
} }
int ucsi_send_command(struct ucsi *ucsi, u64 command, static int ucsi_send_command_common(struct ucsi *ucsi, u64 command,
void *data, size_t size) void *data, size_t size, bool conn_ack)
{ {
u8 length; u8 length;
int ret; int ret;
@ -192,7 +186,7 @@ int ucsi_send_command(struct ucsi *ucsi, u64 command,
goto out; goto out;
} }
ret = ucsi_acknowledge_command(ucsi); ret = ucsi_acknowledge(ucsi, conn_ack);
if (ret) if (ret)
goto out; goto out;
@ -201,6 +195,12 @@ out:
mutex_unlock(&ucsi->ppm_lock); mutex_unlock(&ucsi->ppm_lock);
return ret; return ret;
} }
int ucsi_send_command(struct ucsi *ucsi, u64 command,
void *data, size_t size)
{
return ucsi_send_command_common(ucsi, command, data, size, false);
}
EXPORT_SYMBOL_GPL(ucsi_send_command); EXPORT_SYMBOL_GPL(ucsi_send_command);
/* -------------------------------------------------------------------------- */ /* -------------------------------------------------------------------------- */
@ -1187,7 +1187,9 @@ static void ucsi_handle_connector_change(struct work_struct *work)
mutex_lock(&con->lock); mutex_lock(&con->lock);
command = UCSI_GET_CONNECTOR_STATUS | UCSI_CONNECTOR_NUMBER(con->num); command = UCSI_GET_CONNECTOR_STATUS | UCSI_CONNECTOR_NUMBER(con->num);
ret = ucsi_send_command(ucsi, command, &con->status, sizeof(con->status));
ret = ucsi_send_command_common(ucsi, command, &con->status,
sizeof(con->status), true);
if (ret < 0) { if (ret < 0) {
dev_err(ucsi->dev, "%s: GET_CONNECTOR_STATUS failed (%d)\n", dev_err(ucsi->dev, "%s: GET_CONNECTOR_STATUS failed (%d)\n",
__func__, ret); __func__, ret);
@ -1244,14 +1246,6 @@ static void ucsi_handle_connector_change(struct work_struct *work)
if (con->status.change & UCSI_CONSTAT_CAM_CHANGE) if (con->status.change & UCSI_CONSTAT_CAM_CHANGE)
ucsi_partner_task(con, ucsi_check_altmodes, 1, 0); ucsi_partner_task(con, ucsi_check_altmodes, 1, 0);
mutex_lock(&ucsi->ppm_lock);
clear_bit(EVENT_PENDING, &con->ucsi->flags);
ret = ucsi_acknowledge_connector_change(ucsi);
mutex_unlock(&ucsi->ppm_lock);
if (ret)
dev_err(ucsi->dev, "%s: ACK failed (%d)", __func__, ret);
out_unlock: out_unlock:
mutex_unlock(&con->lock); mutex_unlock(&con->lock);
} }