niansa-misc/linux
1
0
Fork 0
mirror of synced 2025-03-06 20:59:54 +01:00
Code Issues Projects Releases Packages Wiki Activity

IB/srp: replace custom implementation of hex2bin()

Browse source 
There is no need to have a duplication of the generic library, i.e.
hex2bin().

Replace the open coded variant.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Bart Van Assche <bart.vanassche@wdc.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
This commit is contained in:
Andy Shevchenko 2017-12-11 15:05:05 +02:00 • committed by Jason Gunthorpe
parent 1b19b95169
commit e711f968c4
1 changed files with 3 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
drivers/infiniband/ulp/srp/ib_srp.c
View file

@ -3110,7 +3110,6 @@ static int srp_parse_options(const char *buf, struct srp_target_port *target)
{ {
char *options, *sep_opt; char *options, *sep_opt;
char *p; char *p;
char dgid[3];
substring_t args[MAX_OPT_ARGS]; substring_t args[MAX_OPT_ARGS];
int opt_mask = 0; int opt_mask = 0;
int token; int token;
@ -3162,16 +3161,10 @@ static int srp_parse_options(const char *buf, struct srp_target_port *target)
goto out; goto out;
} }
for (i = 0; i < 16; ++i) { ret = hex2bin(target->orig_dgid.raw, p, 16);
strlcpy(dgid, p + i * 2, sizeof(dgid));
if (sscanf(dgid, "%hhx",
&target->orig_dgid.raw[i]) < 1) {
ret = -EINVAL;
kfree(p);
goto out;
}
}
kfree(p); kfree(p);
if (ret < 0)
goto out;
break; break;
case SRP_OPT_PKEY: case SRP_OPT_PKEY: