niansa-misc/linux
1
0
Fork 0
mirror of synced 2025-03-06 20:59:54 +01:00
Code Issues Projects Releases Packages Wiki Activity

staging: rtl8192e: rtllib_module: fix error handle case in alloc_rtllib()

Browse source 
Some variables are leaked in the error handling in alloc_rtllib(), free
the variables in the error path.

Fixes: 94a799425e ("From: wlanfae <wlanfae@realtek.com>")
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Pavel Skripkin <paskripkin@gmail.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20211202030704.2425621-3-yangyingliang@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Yang Yingliang 2021-12-02 11:07:03 +08:00 • committed by Greg Kroah-Hartman
parent 68bf78ff59
commit e730cd57ac
1 changed files with 12 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
drivers/staging/rtl8192e/rtllib_module.c
View file

@ -88,7 +88,7 @@ struct net_device *alloc_rtllib(int sizeof_priv)
err = rtllib_networks_allocate(ieee); err = rtllib_networks_allocate(ieee);
if (err) { if (err) {
pr_err("Unable to allocate beacon storage: %d\n", err); pr_err("Unable to allocate beacon storage: %d\n", err);
goto failed; goto free_netdev;
} }
rtllib_networks_initialize(ieee); rtllib_networks_initialize(ieee);
@ -121,11 +121,13 @@ struct net_device *alloc_rtllib(int sizeof_priv)
ieee->hwsec_active = 0; ieee->hwsec_active = 0;
memset(ieee->swcamtable, 0, sizeof(struct sw_cam_table) * 32); memset(ieee->swcamtable, 0, sizeof(struct sw_cam_table) * 32);
rtllib_softmac_init(ieee); err = rtllib_softmac_init(ieee);
if (err)
goto free_crypt_info;
ieee->pHTInfo = kzalloc(sizeof(struct rt_hi_throughput), GFP_KERNEL); ieee->pHTInfo = kzalloc(sizeof(struct rt_hi_throughput), GFP_KERNEL);
if (!ieee->pHTInfo) if (!ieee->pHTInfo)
return NULL; goto free_softmac;
HTUpdateDefaultSetting(ieee); HTUpdateDefaultSetting(ieee);
HTInitializeHTInfo(ieee); HTInitializeHTInfo(ieee);
@ -141,8 +143,14 @@ struct net_device *alloc_rtllib(int sizeof_priv)
return dev; return dev;
failed: free_softmac:
rtllib_softmac_free(ieee);
free_crypt_info:
lib80211_crypt_info_free(&ieee->crypt_info);
rtllib_networks_free(ieee);
free_netdev:
free_netdev(dev); free_netdev(dev);
return NULL; return NULL;
} }
EXPORT_SYMBOL(alloc_rtllib); EXPORT_SYMBOL(alloc_rtllib);