niansa-misc/linux
1
0
Fork 0
mirror of synced 2025-03-06 20:59:54 +01:00
Code Issues Projects Releases Packages Wiki Activity

drm/i915/gt: Delay release of engine-pm after last retirement

Browse source 
Keep the engine-pm awake until the next jiffie, to avoid immediate
ping-pong under moderate load. (Forcing the idle barrier excerbates the
moderate load, dramatically increasing the driver overhead.) On the
other hand, delaying the idle-barrier slightly incurs longer rc6-off
and so more power consumption.

Closes: https://gitlab.freedesktop.org/drm/intel/issues/848
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200323092841.22240-4-chris@chris-wilson.co.uk
This commit is contained in:
Chris Wilson 2020-03-23 09:28:37 +00:00
parent e9037e7f9a
commit edee52c927
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/gpu/drm/i915/gt/intel_context.c
View file

@ -350,7 +350,7 @@ void intel_context_enter_engine(struct intel_context *ce)
void intel_context_exit_engine(struct intel_context *ce) void intel_context_exit_engine(struct intel_context *ce)
{ {
intel_timeline_exit(ce->timeline); intel_timeline_exit(ce->timeline);
intel_engine_pm_put(ce->engine); intel_engine_pm_put_delay(ce->engine, 1);
} }
int intel_context_prepare_remote_request(struct intel_context *ce, int intel_context_prepare_remote_request(struct intel_context *ce,

2
drivers/gpu/drm/i915/i915_active.c
View file

@ -818,7 +818,7 @@ void i915_active_acquire_barrier(struct i915_active *ref)
GEM_BUG_ON(!intel_engine_pm_is_awake(engine)); GEM_BUG_ON(!intel_engine_pm_is_awake(engine));
llist_add(barrier_to_ll(node), &engine->barrier_tasks); llist_add(barrier_to_ll(node), &engine->barrier_tasks);
intel_engine_pm_put(engine); intel_engine_pm_put_delay(engine, 1);
} }
} }