niansa-misc/linux
1
0
Fork 0
mirror of synced 2025-03-06 20:59:54 +01:00
Code Issues Projects Releases Packages Wiki Activity

crypto: nx - nx842_OF_upd_status should return ENODEV if device is not 'okay'

Browse source 
The current documention mentions explicitly that EINVAL should be
returned if the device is not available, but nx842_OF_upd_status()
always returns 0. However, nx842_probe() specifically checks for
non-ENODEV returns from nx842_of_upd() (which in turn calls
nx842_OF_upd_status()) and emits an extra error in that case. It seems
like the proper return code of a disabled device is ENODEV.

Signed-off-by: Nishanth Aravamudan <nacc@linux.vnet.ibm.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
This commit is contained in:
Nishanth Aravamudan 2015-07-02 15:38:48 -07:00 • committed by Herbert Xu
parent 6170511a91
commit fa9a9a084a
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
drivers/crypto/nx/nx-842-pseries.c
View file

@ -556,7 +556,7 @@ static int nx842_OF_set_defaults(struct nx842_devdata *devdata)
* *
* Returns: * Returns:
* 0 - Device is available * 0 - Device is available
* -EINVAL - Device is not available * -ENODEV - Device is not available
*/ */
static int nx842_OF_upd_status(struct nx842_devdata *devdata, static int nx842_OF_upd_status(struct nx842_devdata *devdata,
struct property *prop) { struct property *prop) {
@ -569,6 +569,7 @@ static int nx842_OF_upd_status(struct nx842_devdata *devdata,
dev_info(devdata->dev, "%s: status '%s' is not 'okay'\n", dev_info(devdata->dev, "%s: status '%s' is not 'okay'\n",
__func__, status); __func__, status);
devdata->status = UNAVAILABLE; devdata->status = UNAVAILABLE;
ret = -ENODEV;
} }
return ret; return ret;