c3bf8e21b3
This patch adds support for generic eDP sink through aux_bus. The eDP/DP controller driver should support aux transactions originating from the panel-edp driver and hence should be initialized and ready. The panel bridge supporting the panel should be ready before the bridge connector is initialized. The generic panel probe needs the controller resources to be enabled to support the aux transactions originating from the panel probe. Signed-off-by: Sankeerth Billakanti <quic_sbillaka@quicinc.com> Reviewed-by: Douglas Anderson <dianders@chromium.org> Reviewed-by: Stephen Boyd <swboyd@chromium.org> Patchwork: https://patchwork.freedesktop.org/patch/483307/ Link: https://lore.kernel.org/r/1650887072-16652-2-git-send-email-quic_sbillaka@quicinc.com Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
144 lines
3.7 KiB
C
144 lines
3.7 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* Copyright (c) 2017-2020, The Linux Foundation. All rights reserved.
|
|
*/
|
|
|
|
#include <drm/drm_atomic_helper.h>
|
|
#include <drm/drm_atomic.h>
|
|
#include <drm/drm_bridge.h>
|
|
#include <drm/drm_bridge_connector.h>
|
|
#include <drm/drm_crtc.h>
|
|
|
|
#include "msm_drv.h"
|
|
#include "msm_kms.h"
|
|
#include "dp_drm.h"
|
|
|
|
/**
|
|
* dp_bridge_detect - callback to determine if connector is connected
|
|
* @bridge: Pointer to drm bridge structure
|
|
* Returns: Bridge's 'is connected' status
|
|
*/
|
|
static enum drm_connector_status dp_bridge_detect(struct drm_bridge *bridge)
|
|
{
|
|
struct msm_dp *dp;
|
|
|
|
dp = to_dp_bridge(bridge)->dp_display;
|
|
|
|
drm_dbg_dp(dp->drm_dev, "is_connected = %s\n",
|
|
(dp->is_connected) ? "true" : "false");
|
|
|
|
return (dp->is_connected) ? connector_status_connected :
|
|
connector_status_disconnected;
|
|
}
|
|
|
|
/**
|
|
* dp_bridge_get_modes - callback to add drm modes via drm_mode_probed_add()
|
|
* @bridge: Poiner to drm bridge
|
|
* @connector: Pointer to drm connector structure
|
|
* Returns: Number of modes added
|
|
*/
|
|
static int dp_bridge_get_modes(struct drm_bridge *bridge, struct drm_connector *connector)
|
|
{
|
|
int rc = 0;
|
|
struct msm_dp *dp;
|
|
|
|
if (!connector)
|
|
return 0;
|
|
|
|
dp = to_dp_bridge(bridge)->dp_display;
|
|
|
|
/* pluggable case assumes EDID is read when HPD */
|
|
if (dp->is_connected) {
|
|
rc = dp_display_get_modes(dp);
|
|
if (rc <= 0) {
|
|
DRM_ERROR("failed to get DP sink modes, rc=%d\n", rc);
|
|
return rc;
|
|
}
|
|
} else {
|
|
drm_dbg_dp(connector->dev, "No sink connected\n");
|
|
}
|
|
return rc;
|
|
}
|
|
|
|
static const struct drm_bridge_funcs dp_bridge_ops = {
|
|
.enable = dp_bridge_enable,
|
|
.disable = dp_bridge_disable,
|
|
.post_disable = dp_bridge_post_disable,
|
|
.mode_set = dp_bridge_mode_set,
|
|
.mode_valid = dp_bridge_mode_valid,
|
|
.get_modes = dp_bridge_get_modes,
|
|
.detect = dp_bridge_detect,
|
|
};
|
|
|
|
struct drm_bridge *dp_bridge_init(struct msm_dp *dp_display, struct drm_device *dev,
|
|
struct drm_encoder *encoder)
|
|
{
|
|
int rc;
|
|
struct msm_dp_bridge *dp_bridge;
|
|
struct drm_bridge *bridge;
|
|
|
|
dp_bridge = devm_kzalloc(dev->dev, sizeof(*dp_bridge), GFP_KERNEL);
|
|
if (!dp_bridge)
|
|
return ERR_PTR(-ENOMEM);
|
|
|
|
dp_bridge->dp_display = dp_display;
|
|
|
|
bridge = &dp_bridge->bridge;
|
|
bridge->funcs = &dp_bridge_ops;
|
|
bridge->type = dp_display->connector_type;
|
|
|
|
/*
|
|
* Many ops only make sense for DP. Why?
|
|
* - Detect/HPD are used by DRM to know if a display is _physically_
|
|
* there, not whether the display is powered on / finished initting.
|
|
* On eDP we assume the display is always there because you can't
|
|
* know until power is applied. If we don't implement the ops DRM will
|
|
* assume our display is always there.
|
|
* - Currently eDP mode reading is driven by the panel driver. This
|
|
* allows the panel driver to properly power itself on to read the
|
|
* modes.
|
|
*/
|
|
if (!dp_display->is_edp) {
|
|
bridge->ops =
|
|
DRM_BRIDGE_OP_DETECT |
|
|
DRM_BRIDGE_OP_HPD |
|
|
DRM_BRIDGE_OP_MODES;
|
|
}
|
|
|
|
drm_bridge_add(bridge);
|
|
|
|
rc = drm_bridge_attach(encoder, bridge, NULL, DRM_BRIDGE_ATTACH_NO_CONNECTOR);
|
|
if (rc) {
|
|
DRM_ERROR("failed to attach bridge, rc=%d\n", rc);
|
|
drm_bridge_remove(bridge);
|
|
|
|
return ERR_PTR(rc);
|
|
}
|
|
|
|
if (dp_display->next_bridge) {
|
|
rc = drm_bridge_attach(dp_display->encoder,
|
|
dp_display->next_bridge, bridge,
|
|
DRM_BRIDGE_ATTACH_NO_CONNECTOR);
|
|
if (rc < 0) {
|
|
DRM_ERROR("failed to attach panel bridge: %d\n", rc);
|
|
drm_bridge_remove(bridge);
|
|
return ERR_PTR(rc);
|
|
}
|
|
}
|
|
|
|
return bridge;
|
|
}
|
|
|
|
/* connector initialization */
|
|
struct drm_connector *dp_drm_connector_init(struct msm_dp *dp_display)
|
|
{
|
|
struct drm_connector *connector = NULL;
|
|
|
|
connector = drm_bridge_connector_init(dp_display->drm_dev, dp_display->encoder);
|
|
if (IS_ERR(connector))
|
|
return connector;
|
|
|
|
drm_connector_attach_encoder(connector, dp_display->encoder);
|
|
|
|
return connector;
|
|
}
|