79af598a5b
When it comes to gamma or degamma luts, nouveau will actually skip the calculation of certain LUTs depending on the head and plane states. For instance, when the head is disabled we don't perform any error checking on the gamma LUT, and likewise if no planes are present and enabled in our atomic state we will skip error checking the degamma LUT. This is a bit of a problem though, since the per-head gamma and degamma props in DRM can be changed even while a head is disabled - a situation which can be triggered by the igt testcase mentioned down below. Originally I thought this was a bit silly and was tempted to just fix the igt test to only set gamma/degamma with the head enabled. After a bit of thinking though I realized we should fix this in nouveau. This is because if a program decides to set an invalid LUT for a head before enabling the head, such a property change would succeed while also making it impossible to turn the head back on until the LUT is removed or corrected - something that could be painful for a user to figure out. So, fix this checking both degamma and gamma LUTs unconditionally during atomic checks. We start by calling nv50_head_atomic_check_lut() regardless of whether the head is active or not in nv50_head_atomic_check(). Then we move the ilut error checking into nv50_head_atomic_check_lut() and add a per-head hook for it, primarily because as a per-CRTC property DRM we want the LUT to be error checked by the head any time it's included in an atomic state. Of course though, actual programming of the degamma lut to hardware is still handled in each plane's atomic check and commit. Signed-off-by: Lyude Paul <lyude@redhat.com> Testcase: igt/kms_color/pipe-invalid-*-lut-sizes Signed-off-by: Ben Skeggs <bskeggs@redhat.com> Reviewed-by: Karol Herbst <kherbst@redhat.com> Signed-off-by: Karol Herbst <kherbst@redhat.com> Link: https://gitlab.freedesktop.org/drm/nouveau/-/merge_requests/10
100 lines
4.2 KiB
C
100 lines
4.2 KiB
C
#ifndef __NV50_KMS_HEAD_H__
|
|
#define __NV50_KMS_HEAD_H__
|
|
#define nv50_head(c) container_of((c), struct nv50_head, base.base)
|
|
#include <linux/workqueue.h>
|
|
|
|
#include "disp.h"
|
|
#include "atom.h"
|
|
#include "crc.h"
|
|
#include "lut.h"
|
|
|
|
#include "nouveau_crtc.h"
|
|
#include "nouveau_encoder.h"
|
|
|
|
struct nv50_head {
|
|
const struct nv50_head_func *func;
|
|
struct nouveau_crtc base;
|
|
struct nv50_crc crc;
|
|
struct nv50_lut olut;
|
|
struct nv50_msto *msto;
|
|
};
|
|
|
|
struct nv50_head *nv50_head_create(struct drm_device *, int index);
|
|
void nv50_head_flush_set(struct nv50_head *head, struct nv50_head_atom *asyh);
|
|
void nv50_head_flush_set_wndw(struct nv50_head *head, struct nv50_head_atom *asyh);
|
|
void nv50_head_flush_clr(struct nv50_head *head,
|
|
struct nv50_head_atom *asyh, bool flush);
|
|
|
|
struct nv50_head_func {
|
|
int (*view)(struct nv50_head *, struct nv50_head_atom *);
|
|
int (*mode)(struct nv50_head *, struct nv50_head_atom *);
|
|
bool (*olut)(struct nv50_head *, struct nv50_head_atom *, int);
|
|
bool (*ilut_check)(int size);
|
|
bool olut_identity;
|
|
int olut_size;
|
|
int (*olut_set)(struct nv50_head *, struct nv50_head_atom *);
|
|
int (*olut_clr)(struct nv50_head *);
|
|
void (*core_calc)(struct nv50_head *, struct nv50_head_atom *);
|
|
int (*core_set)(struct nv50_head *, struct nv50_head_atom *);
|
|
int (*core_clr)(struct nv50_head *);
|
|
int (*curs_layout)(struct nv50_head *, struct nv50_wndw_atom *,
|
|
struct nv50_head_atom *);
|
|
int (*curs_format)(struct nv50_head *, struct nv50_wndw_atom *,
|
|
struct nv50_head_atom *);
|
|
int (*curs_set)(struct nv50_head *, struct nv50_head_atom *);
|
|
int (*curs_clr)(struct nv50_head *);
|
|
int (*base)(struct nv50_head *, struct nv50_head_atom *);
|
|
int (*ovly)(struct nv50_head *, struct nv50_head_atom *);
|
|
int (*dither)(struct nv50_head *, struct nv50_head_atom *);
|
|
int (*procamp)(struct nv50_head *, struct nv50_head_atom *);
|
|
int (*or)(struct nv50_head *, struct nv50_head_atom *);
|
|
void (*static_wndw_map)(struct nv50_head *, struct nv50_head_atom *);
|
|
};
|
|
|
|
extern const struct nv50_head_func head507d;
|
|
int head507d_view(struct nv50_head *, struct nv50_head_atom *);
|
|
int head507d_mode(struct nv50_head *, struct nv50_head_atom *);
|
|
bool head507d_olut(struct nv50_head *, struct nv50_head_atom *, int);
|
|
void head507d_core_calc(struct nv50_head *, struct nv50_head_atom *);
|
|
int head507d_core_clr(struct nv50_head *);
|
|
int head507d_curs_layout(struct nv50_head *, struct nv50_wndw_atom *,
|
|
struct nv50_head_atom *);
|
|
int head507d_curs_format(struct nv50_head *, struct nv50_wndw_atom *,
|
|
struct nv50_head_atom *);
|
|
int head507d_base(struct nv50_head *, struct nv50_head_atom *);
|
|
int head507d_ovly(struct nv50_head *, struct nv50_head_atom *);
|
|
int head507d_dither(struct nv50_head *, struct nv50_head_atom *);
|
|
int head507d_procamp(struct nv50_head *, struct nv50_head_atom *);
|
|
|
|
extern const struct nv50_head_func head827d;
|
|
|
|
extern const struct nv50_head_func head907d;
|
|
int head907d_view(struct nv50_head *, struct nv50_head_atom *);
|
|
int head907d_mode(struct nv50_head *, struct nv50_head_atom *);
|
|
bool head907d_olut(struct nv50_head *, struct nv50_head_atom *, int);
|
|
bool head907d_ilut_check(int size);
|
|
int head907d_olut_set(struct nv50_head *, struct nv50_head_atom *);
|
|
int head907d_olut_clr(struct nv50_head *);
|
|
int head907d_core_set(struct nv50_head *, struct nv50_head_atom *);
|
|
int head907d_core_clr(struct nv50_head *);
|
|
int head907d_curs_set(struct nv50_head *, struct nv50_head_atom *);
|
|
int head907d_curs_clr(struct nv50_head *);
|
|
int head907d_ovly(struct nv50_head *, struct nv50_head_atom *);
|
|
int head907d_procamp(struct nv50_head *, struct nv50_head_atom *);
|
|
int head907d_or(struct nv50_head *, struct nv50_head_atom *);
|
|
|
|
extern const struct nv50_head_func head917d;
|
|
int head917d_curs_layout(struct nv50_head *, struct nv50_wndw_atom *,
|
|
struct nv50_head_atom *);
|
|
|
|
extern const struct nv50_head_func headc37d;
|
|
int headc37d_view(struct nv50_head *, struct nv50_head_atom *);
|
|
int headc37d_curs_format(struct nv50_head *, struct nv50_wndw_atom *,
|
|
struct nv50_head_atom *);
|
|
int headc37d_curs_set(struct nv50_head *, struct nv50_head_atom *);
|
|
int headc37d_curs_clr(struct nv50_head *);
|
|
int headc37d_dither(struct nv50_head *, struct nv50_head_atom *);
|
|
void headc37d_static_wndw_map(struct nv50_head *, struct nv50_head_atom *);
|
|
|
|
extern const struct nv50_head_func headc57d;
|
|
#endif
|