1
0
Fork 0
mirror of synced 2025-03-06 20:59:54 +01:00
linux/drivers/net/ethernet/intel/i40evf
Mitch Williams 1001dc3739 i40e: don't overload fields
Overloading the msg_size field in the arq_event_info struct is just a
bad idea. It leads to repeated bugs when the structure is used in a
loop, since the input value (buffer size) is overwritten by the output
value (actual message length).

Fix this by splitting the field into two and renaming to indicate the
actual function of each field.

Since the arq_event struct has now changed, we need to change the drivers
to support this. Note that we no longer need to initialize the buffer size
each time we go through a loop as this value is no longer destroyed by
arq processing.

In the process, we also fix a bug in i40evf_verify_api_ver where the
buffer size was not correctly reinitialized each time through the loop.

Change-ID: Ic7f9633cdd6f871f93e698dfb095e29c696f5581
Signed-off-by: Mitch Williams <mitch.a.williams@intel.com>
Acked-by: Shannon Nelson <shannon.nelson@intel.com>
Acked-by: Ashish Shah <ashish.n.shah@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
2014-11-20 14:56:42 -08:00
..
i40e_adminq.c i40e: don't overload fields 2014-11-20 14:56:42 -08:00
i40e_adminq.h i40e: don't overload fields 2014-11-20 14:56:42 -08:00
i40e_adminq_cmd.h i40e/i40evf: Fix whitespace indentation 2014-10-23 20:38:03 -07:00
i40e_alloc.h i40evf: Fix the headers and update copyright year. 2014-05-21 01:54:43 -07:00
i40e_common.c i40evf: Add support for 10G base T parts 2014-11-03 01:38:41 -08:00
i40e_hmc.h i40e/i40evf: Force a shifted '1' to be unsigned 2014-07-02 19:02:19 -07:00
i40e_lan_hmc.h i40e/i40evf: Big endian fixes for handling HMC 2014-06-26 04:44:57 -07:00
i40e_osdep.h i40evf: Fix the headers and update copyright year. 2014-05-21 01:54:43 -07:00
i40e_prototype.h i40e/i40evf: add max buf len to aq debug print helper 2014-08-27 00:40:14 -07:00
i40e_register.h i40e/i40evf: i40e_register.h update 2014-06-19 20:22:02 -07:00
i40e_status.h i40evf: Fix the headers and update copyright year. 2014-05-21 01:54:43 -07:00
i40e_txrx.c Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net 2014-09-07 21:41:53 -07:00
i40e_txrx.h i40e: clean up throttle rate code 2014-11-11 06:01:48 -08:00
i40e_type.h i40evf: Add support for 10G base T parts 2014-11-03 01:38:41 -08:00
i40e_virtchnl.h i40e/i40evf: Clean up a few things 2014-06-08 02:01:26 -07:00
i40evf.h i40evf: don't use more queues than CPUs 2014-11-11 06:02:00 -08:00
i40evf_ethtool.c i40evf: don't use more queues than CPUs 2014-11-11 06:02:00 -08:00
i40evf_main.c i40e: don't overload fields 2014-11-20 14:56:42 -08:00
i40evf_virtchnl.c i40e: don't overload fields 2014-11-20 14:56:42 -08:00
Makefile i40evf: Fix the headers and update copyright year. 2014-05-21 01:54:43 -07:00