733a90561a
This makes ptrace/get_syscall_info selftest pass on mips o32 and
mips64 o32 by fixing the following two test assertions:
1. get_syscall_info test assertion on mips o32:
# get_syscall_info.c:218:get_syscall_info:Expected exp_args[5] (3134521044) == info.entry.args[4] (4911432)
# get_syscall_info.c:219:get_syscall_info:wait #1: entry stop mismatch
2. get_syscall_info test assertion on mips64 o32:
# get_syscall_info.c:209:get_syscall_info:Expected exp_args[2] (3134324433) == info.entry.args[1] (18446744072548908753)
# get_syscall_info.c:210:get_syscall_info:wait #1: entry stop mismatch
The first assertion happens due to mips_get_syscall_arg() trying to access
another task's context but failing to do it properly because get_user() it
calls just peeks at the current task's context. It usually does not crash
because the default user stack always gets assigned the same VMA, but it
is pure luck which mips_get_syscall_arg() wouldn't have if e.g. the stack
was switched (via setcontext(3) or however) or a non-default process's
thread peeked at, and in any case irrelevant data is obtained just as
observed with the test case.
mips_get_syscall_arg() ought to be using access_remote_vm() instead to
retrieve the other task's stack contents, but given that the data has been
already obtained and saved in `struct pt_regs' it would be an overkill.
The first assertion is fixed for mips o32 by using struct pt_regs.args
instead of get_user() to obtain syscall arguments. This approach works
due to this piece in arch/mips/kernel/scall32-o32.S:
/*
* Ok, copy the args from the luser stack to the kernel stack.
*/
.set push
.set noreorder
.set nomacro
load_a4: user_lw(t5, 16(t0)) # argument #5 from usp
load_a5: user_lw(t6, 20(t0)) # argument #6 from usp
load_a6: user_lw(t7, 24(t0)) # argument #7 from usp
load_a7: user_lw(t8, 28(t0)) # argument #8 from usp
loads_done:
sw t5, PT_ARG4(sp) # argument #5 to ksp
sw t6, PT_ARG5(sp) # argument #6 to ksp
sw t7, PT_ARG6(sp) # argument #7 to ksp
sw t8, PT_ARG7(sp) # argument #8 to ksp
.set pop
.section __ex_table,"a"
PTR_WD load_a4, bad_stack_a4
PTR_WD load_a5, bad_stack_a5
PTR_WD load_a6, bad_stack_a6
PTR_WD load_a7, bad_stack_a7
.previous
arch/mips/kernel/scall64-o32.S has analogous code for mips64 o32 that
allows fixing the issue by obtaining syscall arguments from struct
pt_regs.regs[4..11] instead of the erroneous use of get_user().
The second assertion is fixed by truncating 64-bit values to 32-bit
syscall arguments.
Fixes: c0ff3c53d4 ("MIPS: Enable HAVE_ARCH_TRACEHOOK.")
Signed-off-by: Dmitry V. Levin <ldv@strace.io>
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
144 lines
3.4 KiB
C
144 lines
3.4 KiB
C
/*
|
|
* Access to user system call parameters and results
|
|
*
|
|
* This file is subject to the terms and conditions of the GNU General Public
|
|
* License. See the file "COPYING" in the main directory of this archive
|
|
* for more details.
|
|
*
|
|
* See asm-generic/syscall.h for descriptions of what we must do here.
|
|
*
|
|
* Copyright (C) 2012 Ralf Baechle <ralf@linux-mips.org>
|
|
*/
|
|
|
|
#ifndef __ASM_MIPS_SYSCALL_H
|
|
#define __ASM_MIPS_SYSCALL_H
|
|
|
|
#include <linux/compiler.h>
|
|
#include <uapi/linux/audit.h>
|
|
#include <linux/elf-em.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/sched.h>
|
|
#include <linux/uaccess.h>
|
|
#include <asm/ptrace.h>
|
|
#include <asm/unistd.h>
|
|
|
|
#ifndef __NR_syscall /* Only defined if _MIPS_SIM == _MIPS_SIM_ABI32 */
|
|
#define __NR_syscall 4000
|
|
#endif
|
|
|
|
static inline bool mips_syscall_is_indirect(struct task_struct *task,
|
|
struct pt_regs *regs)
|
|
{
|
|
/* O32 ABI syscall() - Either 64-bit with O32 or 32-bit */
|
|
return (IS_ENABLED(CONFIG_32BIT) ||
|
|
test_tsk_thread_flag(task, TIF_32BIT_REGS)) &&
|
|
(regs->regs[2] == __NR_syscall);
|
|
}
|
|
|
|
static inline long syscall_get_nr(struct task_struct *task,
|
|
struct pt_regs *regs)
|
|
{
|
|
return task_thread_info(task)->syscall;
|
|
}
|
|
|
|
static inline void mips_syscall_update_nr(struct task_struct *task,
|
|
struct pt_regs *regs)
|
|
{
|
|
/*
|
|
* v0 is the system call number, except for O32 ABI syscall(), where it
|
|
* ends up in a0.
|
|
*/
|
|
if (mips_syscall_is_indirect(task, regs))
|
|
task_thread_info(task)->syscall = regs->regs[4];
|
|
else
|
|
task_thread_info(task)->syscall = regs->regs[2];
|
|
}
|
|
|
|
static inline void mips_get_syscall_arg(unsigned long *arg,
|
|
struct task_struct *task, struct pt_regs *regs, unsigned int n)
|
|
{
|
|
#ifdef CONFIG_32BIT
|
|
switch (n) {
|
|
case 0: case 1: case 2: case 3:
|
|
*arg = regs->regs[4 + n];
|
|
return;
|
|
case 4: case 5: case 6: case 7:
|
|
*arg = regs->args[n];
|
|
return;
|
|
}
|
|
#else
|
|
*arg = regs->regs[4 + n];
|
|
if ((IS_ENABLED(CONFIG_MIPS32_O32) &&
|
|
test_tsk_thread_flag(task, TIF_32BIT_REGS)))
|
|
*arg = (unsigned int)*arg;
|
|
#endif
|
|
}
|
|
|
|
static inline long syscall_get_error(struct task_struct *task,
|
|
struct pt_regs *regs)
|
|
{
|
|
return regs->regs[7] ? -regs->regs[2] : 0;
|
|
}
|
|
|
|
static inline long syscall_get_return_value(struct task_struct *task,
|
|
struct pt_regs *regs)
|
|
{
|
|
return regs->regs[2];
|
|
}
|
|
|
|
static inline void syscall_rollback(struct task_struct *task,
|
|
struct pt_regs *regs)
|
|
{
|
|
/* Do nothing */
|
|
}
|
|
|
|
static inline void syscall_set_return_value(struct task_struct *task,
|
|
struct pt_regs *regs,
|
|
int error, long val)
|
|
{
|
|
if (error) {
|
|
regs->regs[2] = -error;
|
|
regs->regs[7] = 1;
|
|
} else {
|
|
regs->regs[2] = val;
|
|
regs->regs[7] = 0;
|
|
}
|
|
}
|
|
|
|
static inline void syscall_get_arguments(struct task_struct *task,
|
|
struct pt_regs *regs,
|
|
unsigned long *args)
|
|
{
|
|
unsigned int i = 0;
|
|
unsigned int n = 6;
|
|
|
|
/* O32 ABI syscall() */
|
|
if (mips_syscall_is_indirect(task, regs))
|
|
i++;
|
|
|
|
while (n--)
|
|
mips_get_syscall_arg(args++, task, regs, i++);
|
|
}
|
|
|
|
extern const unsigned long sys_call_table[];
|
|
extern const unsigned long sys32_call_table[];
|
|
extern const unsigned long sysn32_call_table[];
|
|
|
|
static inline int syscall_get_arch(struct task_struct *task)
|
|
{
|
|
int arch = AUDIT_ARCH_MIPS;
|
|
#ifdef CONFIG_64BIT
|
|
if (!test_tsk_thread_flag(task, TIF_32BIT_REGS)) {
|
|
arch |= __AUDIT_ARCH_64BIT;
|
|
/* N32 sets only TIF_32BIT_ADDR */
|
|
if (test_tsk_thread_flag(task, TIF_32BIT_ADDR))
|
|
arch |= __AUDIT_ARCH_CONVENTION_MIPS64_N32;
|
|
}
|
|
#endif
|
|
#if defined(__LITTLE_ENDIAN)
|
|
arch |= __AUDIT_ARCH_LE;
|
|
#endif
|
|
return arch;
|
|
}
|
|
|
|
#endif /* __ASM_MIPS_SYSCALL_H */
|