1751f872cc
Add the const qualifier to all the ctl_tables in the tree except for
watchdog_hardlockup_sysctl, memory_allocation_profiling_sysctls,
loadpin_sysctl_table and the ones calling register_net_sysctl (./net,
drivers/inifiniband dirs). These are special cases as they use a
registration function with a non-const qualified ctl_table argument or
modify the arrays before passing them on to the registration function.
Constifying ctl_table structs will prevent the modification of
proc_handler function pointers as the arrays would reside in .rodata.
This is made possible after commit 78eb4ea25c ("sysctl: treewide:
constify the ctl_table argument of proc_handlers") constified all the
proc_handlers.
Created this by running an spatch followed by a sed command:
Spatch:
virtual patch
@
depends on !(file in "net")
disable optional_qualifier
@
identifier table_name != {
watchdog_hardlockup_sysctl,
iwcm_ctl_table,
ucma_ctl_table,
memory_allocation_profiling_sysctls,
loadpin_sysctl_table
};
@@
+ const
struct ctl_table table_name [] = { ... };
sed:
sed --in-place \
-e "s/struct ctl_table .table = &uts_kern/const struct ctl_table *table = \&uts_kern/" \
kernel/utsname_sysctl.c
Reviewed-by: Song Liu <song@kernel.org>
Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org> # for kernel/trace/
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com> # SCSI
Reviewed-by: Darrick J. Wong <djwong@kernel.org> # xfs
Acked-by: Jani Nikula <jani.nikula@intel.com>
Acked-by: Corey Minyard <cminyard@mvista.com>
Acked-by: Wei Liu <wei.liu@kernel.org>
Acked-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Bill O'Donnell <bodonnel@redhat.com>
Acked-by: Baoquan He <bhe@redhat.com>
Acked-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
Acked-by: Anna Schumaker <anna.schumaker@oracle.com>
Signed-off-by: Joel Granados <joel.granados@kernel.org>
92 lines
2.3 KiB
C
92 lines
2.3 KiB
C
// SPDX-License-Identifier: MIT
|
|
/*
|
|
* Copyright © 2023-2024 Intel Corporation
|
|
*/
|
|
|
|
#include <linux/errno.h>
|
|
#include <linux/sysctl.h>
|
|
|
|
#include <uapi/drm/xe_drm.h>
|
|
|
|
#include "xe_oa.h"
|
|
#include "xe_observation.h"
|
|
|
|
u32 xe_observation_paranoid = true;
|
|
static struct ctl_table_header *sysctl_header;
|
|
|
|
static int xe_oa_ioctl(struct drm_device *dev, struct drm_xe_observation_param *arg,
|
|
struct drm_file *file)
|
|
{
|
|
switch (arg->observation_op) {
|
|
case DRM_XE_OBSERVATION_OP_STREAM_OPEN:
|
|
return xe_oa_stream_open_ioctl(dev, arg->param, file);
|
|
case DRM_XE_OBSERVATION_OP_ADD_CONFIG:
|
|
return xe_oa_add_config_ioctl(dev, arg->param, file);
|
|
case DRM_XE_OBSERVATION_OP_REMOVE_CONFIG:
|
|
return xe_oa_remove_config_ioctl(dev, arg->param, file);
|
|
default:
|
|
return -EINVAL;
|
|
}
|
|
}
|
|
|
|
/**
|
|
* xe_observation_ioctl - The top level observation layer ioctl
|
|
* @dev: @drm_device
|
|
* @data: pointer to struct @drm_xe_observation_param
|
|
* @file: @drm_file
|
|
*
|
|
* The function is called for different observation streams types and
|
|
* allows execution of different operations supported by those stream
|
|
* types.
|
|
*
|
|
* Return: 0 on success or a negative error code on failure.
|
|
*/
|
|
int xe_observation_ioctl(struct drm_device *dev, void *data, struct drm_file *file)
|
|
{
|
|
struct drm_xe_observation_param *arg = data;
|
|
|
|
if (arg->extensions)
|
|
return -EINVAL;
|
|
|
|
switch (arg->observation_type) {
|
|
case DRM_XE_OBSERVATION_TYPE_OA:
|
|
return xe_oa_ioctl(dev, arg, file);
|
|
default:
|
|
return -EINVAL;
|
|
}
|
|
}
|
|
|
|
static const struct ctl_table observation_ctl_table[] = {
|
|
{
|
|
.procname = "observation_paranoid",
|
|
.data = &xe_observation_paranoid,
|
|
.maxlen = sizeof(xe_observation_paranoid),
|
|
.mode = 0644,
|
|
.proc_handler = proc_dointvec_minmax,
|
|
.extra1 = SYSCTL_ZERO,
|
|
.extra2 = SYSCTL_ONE,
|
|
},
|
|
};
|
|
|
|
/**
|
|
* xe_observation_sysctl_register - Register xe_observation_paranoid sysctl
|
|
*
|
|
* Normally only superuser/root can access observation stream
|
|
* data. However, superuser can set xe_observation_paranoid sysctl to 0 to
|
|
* allow non-privileged users to also access observation data.
|
|
*
|
|
* Return: always returns 0
|
|
*/
|
|
int xe_observation_sysctl_register(void)
|
|
{
|
|
sysctl_header = register_sysctl("dev/xe", observation_ctl_table);
|
|
return 0;
|
|
}
|
|
|
|
/**
|
|
* xe_observation_sysctl_unregister - Unregister xe_observation_paranoid sysctl
|
|
*/
|
|
void xe_observation_sysctl_unregister(void)
|
|
{
|
|
unregister_sysctl_table(sysctl_header);
|
|
}
|