1
0
Fork 0
mirror of synced 2025-03-06 20:59:54 +01:00
linux/sound/soc/sof/intel
Pierre-Louis Bossart bd9038faa9
ASoC: SOF: Intel: soundwire: fix select/depend unmet dependencies
The LKP bot reports the following issue:

WARNING: unmet direct dependencies detected for SOUNDWIRE_INTEL
  Depends on [m]: SOUNDWIRE [=m] && ACPI [=y] && SND_SOC [=y]
  Selected by [y]:
  - SND_SOC_SOF_INTEL_SOUNDWIRE [=y] && SOUND [=y] && !UML &&
  SND [=y] && SND_SOC [=y] && SND_SOC_SOF_TOPLEVEL [=y] &&
  SND_SOC_SOF_INTEL_TOPLEVEL [=y] && SND_SOC_SOF_INTEL_PCI [=y]

This comes from having tristates being configured independently, when
in practice the CONFIG_SOUNDWIRE needs to be aligned with the SOF
choices: when the SOF code is compiled as built-in, the
CONFIG_SOUNDWIRE also needs to be 'y'.

The easiest fix is to replace the 'depends' with a 'select' and have a
single user selection to activate SoundWire on Intel platforms. This
still allows regmap to be compiled independently as a module.

This is just a temporary fix, the select/depend usage will be
revisited and the SOF Kconfig re-organized, as suggested by Arnd
Bergman.

Reported-by: kernel test robot <lkp@intel.com>
Fixes: a115ab9b8b ('ASoC: SOF: Intel: add build support for SoundWire')
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20210122005725.94163-2-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
2021-01-25 12:53:41 +00:00
..
apl.c ASoC: SOF: Intel: hda: define parse_platform_ext_manifest op 2020-11-27 17:23:04 +00:00
bdw.c ASoC: SOF: rename cores_mask to host_managed_cores_mask 2020-09-11 15:29:29 +01:00
byt.c ASoC: SOF: modify the SOF_DBG flags 2020-12-11 13:22:57 +00:00
cnl.c ASoC: SOF: Intel: hda: add sof_icl_ops for ICL platforms 2020-11-27 17:23:07 +00:00
ext_manifest.h ASoC: SOF: ext_manifest: parse cavs extra config data elem 2020-11-27 17:23:05 +00:00
hda-bus.c ASoC: SOF/Intel: clarify SPDX license with GPL-2.0-only 2020-05-01 17:45:24 +01:00
hda-codec.c ASoC: SOF: Intel: fix page fault at probe if i915 init fails 2021-01-13 16:33:40 +00:00
hda-compress.c ASoC: SOF/Intel: clarify SPDX license with GPL-2.0-only 2020-05-01 17:45:24 +01:00
hda-ctrl.c ASoC: SOF/Intel: clarify SPDX license with GPL-2.0-only 2020-05-01 17:45:24 +01:00
hda-dai.c treewide: Use fallthrough pseudo-keyword 2020-08-23 17:36:59 -05:00
hda-dsp.c ASoC: SOF: Intel: hda: Avoid checking jack on system suspend 2021-01-13 15:24:07 +00:00
hda-ipc.c ASoC: SOF/Intel: clarify SPDX license with GPL-2.0-only 2020-05-01 17:45:24 +01:00
hda-ipc.h ASoC: SOF: Intel: hda: Add sof_tgl_ops for TGL platforms 2020-08-27 14:22:23 +01:00
hda-loader.c ASoC: SOF: Intel: hda: fix the condition passed to sof_dev_dbg_or_err 2020-12-11 13:22:58 +00:00
hda-pcm.c ASoC: SOF: Intel: add hw specific PCM constraints 2020-11-19 13:00:04 +00:00
hda-stream.c ASoC: SOF: Intel: hda: Add helper function to program ICCMAX stream 2020-08-27 14:22:19 +01:00
hda-trace.c ASoC: SOF/Intel: clarify SPDX license with GPL-2.0-only 2020-05-01 17:45:24 +01:00
hda.c ASoC: SOF: Intel: hda: fix the condition passed to sof_dev_dbg_or_err 2020-12-11 13:22:58 +00:00
hda.h ASoC: SOF: Intel: hda: Modify existing helper to disable WAKEEN 2021-01-13 15:24:06 +00:00
icl.c ASoC: SOF: Intel: hda: add sof_icl_ops for ICL platforms 2020-11-27 17:23:07 +00:00
intel-ipc.c ASoC: SOF: Intel: add hw specific PCM constraints 2020-11-19 13:00:04 +00:00
Kconfig ASoC: SOF: Intel: soundwire: fix select/depend unmet dependencies 2021-01-25 12:53:41 +00:00
Makefile ASoC: SOF: Intel: hda: add sof_icl_ops for ICL platforms 2020-11-27 17:23:07 +00:00
shim.h ASoC: SOF: rename cores_mask to host_managed_cores_mask 2020-09-11 15:29:29 +01:00
tgl.c ASoC: SOF: Intel: hda: define parse_platform_ext_manifest op 2020-11-27 17:23:04 +00:00