79990cf5e7
If ice_ena_vfs() fails after calling ice_create_vf_entries(), it frees
all VFs without removing them from snapshot PF-VF mailbox list, leading
to list corruption.
Reproducer:
devlink dev eswitch set $PF1_PCI mode switchdev
ip l s $PF1 up
ip l s $PF1 promisc on
sleep 1
echo 1 > /sys/class/net/$PF1/device/sriov_numvfs
sleep 1
echo 1 > /sys/class/net/$PF1/device/sriov_numvfs
Trace (minimized):
list_add corruption. next->prev should be prev (ffff8882e241c6f0), but was 0000000000000000. (next=ffff888455da1330).
kernel BUG at lib/list_debug.c:29!
RIP: 0010:__list_add_valid_or_report+0xa6/0x100
ice_mbx_init_vf_info+0xa7/0x180 [ice]
ice_initialize_vf_entry+0x1fa/0x250 [ice]
ice_sriov_configure+0x8d7/0x1520 [ice]
? __percpu_ref_switch_mode+0x1b1/0x5d0
? __pfx_ice_sriov_configure+0x10/0x10 [ice]
Sometimes a KASAN report can be seen instead with a similar stack trace:
BUG: KASAN: use-after-free in __list_add_valid_or_report+0xf1/0x100
VFs are added to this list in ice_mbx_init_vf_info(), but only removed
in ice_free_vfs(). Move the removing to ice_free_vf_entries(), which is
also being called in other places where VFs are being removed (including
ice_free_vfs() itself).
Fixes: 8cd8a6b17d ("ice: move VF overflow message count into struct ice_mbx_vf_info")
Reported-by: Sujai Buvaneswaran <sujai.buvaneswaran@intel.com>
Closes: https://lore.kernel.org/intel-wired-lan/PH0PR11MB50138B635F2E5CEB7075325D961F2@PH0PR11MB5013.namprd11.prod.outlook.com
Reviewed-by: Martyna Szapar-Mudlaw <martyna.szapar-mudlaw@linux.intel.com>
Signed-off-by: Marcin Szycik <marcin.szycik@linux.intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Tested-by: Sujai Buvaneswaran <sujai.buvaneswaran@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Link: https://patch.msgid.link/20250224190647.3601930-2-anthony.l.nguyen@intel.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
43 lines
1.7 KiB
C
43 lines
1.7 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
/* Copyright (C) 2018-2021, Intel Corporation. */
|
|
|
|
#ifndef _ICE_VF_LIB_PRIVATE_H_
|
|
#define _ICE_VF_LIB_PRIVATE_H_
|
|
|
|
#include "ice_vf_lib.h"
|
|
|
|
/* This header file is for exposing functions in ice_vf_lib.c to other files
|
|
* which are also conditionally compiled depending on CONFIG_PCI_IOV.
|
|
* Functions which may be used by other files should be exposed as part of
|
|
* ice_vf_lib.h
|
|
*
|
|
* Functions in this file are exposed only when CONFIG_PCI_IOV is enabled, and
|
|
* thus this header must not be included by .c files which may be compiled
|
|
* with CONFIG_PCI_IOV disabled.
|
|
*
|
|
* To avoid this, only include this header file directly within .c files that
|
|
* are conditionally enabled in the "ice-$(CONFIG_PCI_IOV)" block.
|
|
*/
|
|
|
|
#ifndef CONFIG_PCI_IOV
|
|
#warning "Only include ice_vf_lib_private.h in CONFIG_PCI_IOV virtualization files"
|
|
#endif
|
|
|
|
void ice_initialize_vf_entry(struct ice_vf *vf);
|
|
void ice_deinitialize_vf_entry(struct ice_vf *vf);
|
|
void ice_dis_vf_qs(struct ice_vf *vf);
|
|
int ice_check_vf_init(struct ice_vf *vf);
|
|
enum virtchnl_status_code ice_err_to_virt_err(int err);
|
|
struct ice_port_info *ice_vf_get_port_info(struct ice_vf *vf);
|
|
int ice_vsi_apply_spoofchk(struct ice_vsi *vsi, bool enable);
|
|
bool ice_is_vf_trusted(struct ice_vf *vf);
|
|
bool ice_vf_has_no_qs_ena(struct ice_vf *vf);
|
|
bool ice_is_vf_link_up(struct ice_vf *vf);
|
|
void ice_vf_ctrl_invalidate_vsi(struct ice_vf *vf);
|
|
void ice_vf_ctrl_vsi_release(struct ice_vf *vf);
|
|
struct ice_vsi *ice_vf_ctrl_vsi_setup(struct ice_vf *vf);
|
|
int ice_vf_init_host_cfg(struct ice_vf *vf, struct ice_vsi *vsi);
|
|
void ice_vf_invalidate_vsi(struct ice_vf *vf);
|
|
void ice_vf_vsi_release(struct ice_vf *vf);
|
|
|
|
#endif /* _ICE_VF_LIB_PRIVATE_H_ */
|