1
0
Fork 0
mirror of synced 2025-03-06 20:59:54 +01:00
linux/drivers/net/wireless/rt2x00
Stanislaw Gruszka 3780d038fd rt2x00: fix random stalls
Is possible that we stop queue and then do not wake up it again,
especially when packets are transmitted fast. That can be easily
reproduced with modified tx queue entry_num to some small value e.g. 16.

If mac80211 already hold local->queue_stop_reason_lock, then we can wait
on that lock in both rt2x00queue_pause_queue() and
rt2x00queue_unpause_queue(). After drooping ->queue_stop_reason_lock
is possible that __ieee80211_wake_queue() will be performed before
__ieee80211_stop_queue(), hence we stop queue and newer wake up it
again.

Another race condition is possible when between rt2x00queue_threshold()
check and rt2x00queue_pause_queue() we will process all pending tx
buffers on different cpu. This might happen if for example interrupt
will be triggered on cpu performing rt2x00mac_tx().

To prevent race conditions serialize pause/unpause by queue->tx_lock.

Cc: stable@vger.kernel.org
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Acked-by: Gertjan van Wingerde <gwingerde@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2012-03-12 14:00:17 -04:00
..
Kconfig rt2x00: Enabled rt35xx device support by default. 2011-06-01 15:10:59 -04:00
Makefile rt2x00: Merge rt2x00ht.c contents in other files. 2011-04-19 15:39:56 -04:00
rt2x00.h rt2x00: RT3593 is also applicable to USB. 2012-01-04 14:31:46 -05:00
rt2x00config.c rt2x00: fix rmmod crash 2011-06-06 15:24:18 -04:00
rt2x00crypto.c rt2x00: Don't use queue entry as parameter when creating TX descriptor. 2011-07-07 13:20:58 -04:00
rt2x00debug.c rt2x00: Split rt2x00dev->flags 2011-04-19 15:39:11 -04:00
rt2x00debug.h
rt2x00dev.c rt2x00: fix random stalls 2012-03-12 14:00:17 -04:00
rt2x00dump.h Fix common misspellings 2011-03-31 11:26:23 -03:00
rt2x00firmware.c rt2x00: Split rt2x00dev->flags 2011-04-19 15:39:11 -04:00
rt2x00leds.c
rt2x00leds.h
rt2x00lib.h rt2x00: Fix compilation without CONFIG_RT2X00_LIB_CRYPTO 2011-08-02 13:48:14 -04:00
rt2x00link.c Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-next-2.6 into for-davem 2011-04-25 14:34:25 -04:00
rt2x00mac.c rt2x00: fix random stalls 2012-03-12 14:00:17 -04:00
rt2x00pci.c rt2x00: Allow dynamic addition of PCI/USB IDs. 2011-04-19 15:39:45 -04:00
rt2x00pci.h rt2x00: Allow dynamic addition of PCI/USB IDs. 2011-04-19 15:39:45 -04:00
rt2x00queue.c rt2x00: fix random stalls 2012-03-12 14:00:17 -04:00
rt2x00queue.h rt2x00: Add WCID to HT TX descriptor 2011-09-14 13:56:56 -04:00
rt2x00reg.h rt2x00: Remove STATE_RADIO_IRQ_OFF_ISR and STATE_RADIO_IRQ_ON_ISR 2011-01-31 15:06:24 -05:00
rt2x00soc.c rt2x00: Use ioremap for SoC devices instead of KSEG1ADDR. 2010-11-17 16:18:54 -05:00
rt2x00soc.h
rt2x00usb.c rt2x00usb: Zero USB padding before sending URB 2012-01-04 14:31:46 -05:00
rt2x00usb.h Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-next-2.6 into for-davem 2011-05-05 13:32:35 -04:00
rt61pci.c module_param: make bool parameters really bool (net & drivers/net) 2011-12-19 22:27:29 -05:00
rt61pci.h rt2x00: Fix WMM Queue naming 2010-12-13 15:23:36 -05:00
rt73usb.c Merge branch 'driver-core-next' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core 2012-01-07 12:03:30 -08:00
rt73usb.h rt2x00: Fix WMM Queue naming 2010-12-13 15:23:36 -05:00
rt2400pci.c Revert "rt2x00: handle spurious pci interrupts" 2011-11-22 16:36:35 -05:00
rt2400pci.h rt2x00: checkpatch.pl error fixes for rt2400pci.h 2010-11-15 13:26:13 -05:00
rt2500pci.c Revert "rt2x00: handle spurious pci interrupts" 2011-11-22 16:36:35 -05:00
rt2500pci.h rt2x00: checkpatch.pl error fixes for rt2500pci.h 2010-11-15 13:26:15 -05:00
rt2500usb.c Merge branch 'driver-core-next' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core 2012-01-07 12:03:30 -08:00
rt2500usb.h
rt2800.h rt2x00: Change RF3853 to RF3053. 2012-01-04 14:31:46 -05:00
rt2800lib.c rt2800lib: fix wrong -128dBm when signal is stronger than -12dBm 2012-02-01 15:25:59 -05:00
rt2800lib.h mac80211: pass vif param to conf_tx() callback 2011-10-03 15:22:41 -04:00
rt2800pci.c rt2800pci: fix spurious interrupts generation 2012-01-13 14:40:57 -05:00
rt2800pci.h rt2x00: checkpatch.pl error fixes for rt2800pci.h 2010-11-15 13:26:20 -05:00
rt2800usb.c Merge branch 'driver-core-next' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core 2012-01-07 12:03:30 -08:00
rt2800usb.h rt2x00: checkpatch.pl error fixes for rt2800usb.h 2010-11-15 13:26:23 -05:00