a441c0aca4
In case of legacy cursor update, the cursor VMA needs to be unpinned only after vblank. This exceeds the lifetime of the whole atomic commit. Any trick I attempted to keep the atomic commit alive didn't work, as drm_atomic_helper_setup_commit() force throttles on any old commit that wasn't cleaned up. The only option remaining is to remove the plane from the atomic commit, and use the same path as the legacy cursor update to clean the state after vblank. Changes since previous version: - Call the memset for plane state immediately when scheduling vblank, this prevents a use-after-free in cursor cleanup. Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Reviewed-by: Uma Shankar <uma.shankar@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20240522053341.137592-4-maarten.lankhorst@linux.intel.com
77 lines
3.2 KiB
C
77 lines
3.2 KiB
C
/* SPDX-License-Identifier: MIT */
|
|
/*
|
|
* Copyright © 2019 Intel Corporation
|
|
*/
|
|
|
|
#ifndef __INTEL_ATOMIC_PLANE_H__
|
|
#define __INTEL_ATOMIC_PLANE_H__
|
|
|
|
#include <linux/types.h>
|
|
|
|
struct drm_plane;
|
|
struct drm_property;
|
|
struct drm_rect;
|
|
struct intel_atomic_state;
|
|
struct intel_crtc;
|
|
struct intel_crtc_state;
|
|
struct intel_plane;
|
|
struct intel_plane_state;
|
|
enum plane_id;
|
|
|
|
unsigned int intel_adjusted_rate(const struct drm_rect *src,
|
|
const struct drm_rect *dst,
|
|
unsigned int rate);
|
|
unsigned int intel_plane_pixel_rate(const struct intel_crtc_state *crtc_state,
|
|
const struct intel_plane_state *plane_state);
|
|
|
|
unsigned int intel_plane_data_rate(const struct intel_crtc_state *crtc_state,
|
|
const struct intel_plane_state *plane_state,
|
|
int color_plane);
|
|
void intel_plane_copy_uapi_to_hw_state(struct intel_plane_state *plane_state,
|
|
const struct intel_plane_state *from_plane_state,
|
|
struct intel_crtc *crtc);
|
|
void intel_plane_copy_hw_state(struct intel_plane_state *plane_state,
|
|
const struct intel_plane_state *from_plane_state);
|
|
void intel_plane_async_flip(struct intel_plane *plane,
|
|
const struct intel_crtc_state *crtc_state,
|
|
const struct intel_plane_state *plane_state,
|
|
bool async_flip);
|
|
void intel_plane_update_noarm(struct intel_plane *plane,
|
|
const struct intel_crtc_state *crtc_state,
|
|
const struct intel_plane_state *plane_state);
|
|
void intel_plane_update_arm(struct intel_plane *plane,
|
|
const struct intel_crtc_state *crtc_state,
|
|
const struct intel_plane_state *plane_state);
|
|
void intel_plane_disable_arm(struct intel_plane *plane,
|
|
const struct intel_crtc_state *crtc_state);
|
|
struct intel_plane *intel_plane_alloc(void);
|
|
void intel_plane_free(struct intel_plane *plane);
|
|
struct drm_plane_state *intel_plane_duplicate_state(struct drm_plane *plane);
|
|
void intel_plane_destroy_state(struct drm_plane *plane,
|
|
struct drm_plane_state *state);
|
|
void intel_crtc_planes_update_noarm(struct intel_atomic_state *state,
|
|
struct intel_crtc *crtc);
|
|
void intel_crtc_planes_update_arm(struct intel_atomic_state *state,
|
|
struct intel_crtc *crtc);
|
|
int intel_plane_atomic_check_with_state(const struct intel_crtc_state *old_crtc_state,
|
|
struct intel_crtc_state *crtc_state,
|
|
const struct intel_plane_state *old_plane_state,
|
|
struct intel_plane_state *intel_state);
|
|
int intel_plane_atomic_check(struct intel_atomic_state *state,
|
|
struct intel_plane *plane);
|
|
int intel_plane_calc_min_cdclk(struct intel_atomic_state *state,
|
|
struct intel_plane *plane,
|
|
bool *need_cdclk_calc);
|
|
int intel_atomic_plane_check_clipping(struct intel_plane_state *plane_state,
|
|
struct intel_crtc_state *crtc_state,
|
|
int min_scale, int max_scale,
|
|
bool can_position);
|
|
int intel_plane_check_src_coordinates(struct intel_plane_state *plane_state);
|
|
void intel_plane_set_invisible(struct intel_crtc_state *crtc_state,
|
|
struct intel_plane_state *plane_state);
|
|
void intel_plane_helper_add(struct intel_plane *plane);
|
|
bool intel_plane_needs_physical(struct intel_plane *plane);
|
|
void intel_plane_init_cursor_vblank_work(struct intel_plane_state *old_plane_state,
|
|
struct intel_plane_state *new_plane_state);
|
|
|
|
#endif /* __INTEL_ATOMIC_PLANE_H__ */
|